All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] utils/readme.txt: fix typos for size-stats-compare
Date: Sun, 2 Jul 2017 14:26:25 +0200	[thread overview]
Message-ID: <20170702122625.GZ29444@argentina> (raw)
In-Reply-To: <20170701182129.GE3593@scaer>

On Sat, Jul 01, 2017 at 08:21:29PM +0200, Yann E. MORIN wrote:
> Thomas, All,
> 
> On 2017-07-01 20:00 +0200, Thomas De Schampheleire spake thusly:
> > A few typos sneaked into the new utils readme...
> 
> Yup, sorry...
> 
> > Additionally, I formulated the list of use cases a bit differently.
> > 
> > Signed-off-by: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
> > ---
> >  utils/readme.txt | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/utils/readme.txt b/utils/readme.txt
> > index a90805fb0..fd20e8ee6 100644
> > --- a/utils/readme.txt
> > +++ b/utils/readme.txt
> > @@ -28,10 +28,10 @@ scanpypi
> >      a script to create a Buildroot package by scanning a PyPI package
> >      description.
> >  
> > -size-stat-compare
> > -    a script to compare the rootfs size between two differnt Buildroot
> > +size-stats-compare
> > +    a script to compare the rootfs size between two different Buildroot
> >      configurations. This can be used to identify the size impact of
> > -    a specific option, or of a set of specific options, or an update
> > +    a specific option, of a set of specific options, or of an update
> 
> I still believe the current situation is prefereable, because it is :
> 
> the impact of
>     - a specific option, or of a set of options,
>   or
>     - a new buildroot version
> 
> (use of the Oxford comma is very important, here! ;-] )

Just to make sure we settle this ;-)
The way I see it, the expanded version would be:

... the impact of a specific option, the impact of a set of options, or the
impact of a new buildroot version.

which I would shorten to either of:

... the impact of a specific option, a set of options, or a new buildroot
version.

... the impact of a specific option or set of options, or of a new buildroot
version.

and perhaps other variants, but I feel that _if_ you repeat 'of' in the 'of a
set of options' part, then you must also repeat it in the 'new buildroot
version' part.

Anyway, who reads these readme's anyway? ;-)

/Thomas

  reply	other threads:[~2017-07-02 12:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-01 18:00 [Buildroot] [PATCH 1/1] utils/readme.txt: fix typos for size-stats-compare Thomas De Schampheleire
2017-07-01 18:21 ` Yann E. MORIN
2017-07-02 12:26   ` Thomas De Schampheleire [this message]
2017-07-01 22:35 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170702122625.GZ29444@argentina \
    --to=thomas.de_schampheleire@nokia.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.