All of lore.kernel.org
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Christoph Hellwig <hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
Cc: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Sagi Grimberg <sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>,
	Chuck Lever <chuck.lever-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH rdma-next V1] RDMA/rw: Remove force_mr module parameter
Date: Sun, 2 Jul 2017 20:56:49 +0300	[thread overview]
Message-ID: <20170702175649.GE8041@mtr-leonro.local> (raw)
In-Reply-To: <20170702153532.GA18051-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 594 bytes --]

On Sun, Jul 02, 2017 at 08:35:32AM -0700, Christoph Hellwig wrote:
> NAK.  It's a very useful debug helper and should instead also be
> exposed at runtime.

So dramatic,
Last time, you wrote that you (AUTHOR) didn't use this module parameter,
so what did happen from that post?

----
https://www.spinics.net/lists/linux-rdma/msg49891.html
I think I only added it on requests from someone (you?), and when
writing the code debugged it by manually forcing it to on.
----

No one is removing the logic and the code in the IB/core, the change is
here is in removing visibility to the user.

Thanks

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

      parent reply	other threads:[~2017-07-02 17:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-02  6:24 [PATCH rdma-next V1] RDMA/rw: Remove force_mr module parameter Leon Romanovsky
     [not found] ` <20170702062425.6780-1-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-07-02 15:35   ` Christoph Hellwig
     [not found]     ` <20170702153532.GA18051-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2017-07-02 17:56       ` Leon Romanovsky [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170702175649.GE8041@mtr-leonro.local \
    --to=leon-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
    --cc=chuck.lever-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
    --cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.