All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 3/4] toolchain-external: copy ld*.so* for all C libraries
Date: Sun, 2 Jul 2017 23:51:27 +0200	[thread overview]
Message-ID: <20170702235127.14b7ca48@windsurf> (raw)
In-Reply-To: <CAAXf6LW0KBCQnS-oVUzPLtY9S1CpNou9e+0JmZudu+vy0DjrNg@mail.gmail.com>

Hello,

On Sun, 2 Jul 2017 21:21:46 +0200, Thomas De Schampheleire wrote:

> > diff --git a/toolchain/toolchain-external/pkg-toolchain-external.mk b/toolchain/toolchain-external/pkg-toolchain-external.mk
> > index 8460e37..c1c3900 100644
> > --- a/toolchain/toolchain-external/pkg-toolchain-external.mk
> > +++ b/toolchain/toolchain-external/pkg-toolchain-external.mk
> > @@ -107,13 +107,11 @@ endif
> >  #
> >  # Definitions of the list of libraries that should be copied to the target.
> >  #
> > +
> > +TOOLCHAIN_EXTERNAL_LIBS += ld*.so*  
> 
> In copy_toolchain_sysroot, the patterns ld*.so and ld*.so.* are
> treated separately. I think the only reason must be to avoid matching
> ld*.something (I can't think of another reason at this moment).
> Perhaps that is too far-fetched, and copy_toolchain_sysroot should be
> updated, but in any case it makes sense to line up.

I think it's a separate issue, because we're already using ld*.so*
today in pkg-toolchain-external.mk for TOOLCHAIN_EXTERNAL_LIBS, I'm
just moving it around.

However, I agree we should probably line up things. In which direction
do you think we should line up? I guess using ld*.so* in
copy_toolchain_sysroot should be fine.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  reply	other threads:[~2017-07-02 21:51 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-02 13:41 [Buildroot] [PATCH 0/4] Solving the musl dynamic linker issues Thomas Petazzoni
2017-07-02 13:41 ` [Buildroot] [PATCH 1/4] support/testing: add tests for musl and uclibc toolchains Thomas Petazzoni
2017-07-02 13:43   ` Thomas Petazzoni
2017-07-03 13:15   ` Arnout Vandecappelle
2017-07-02 13:41 ` [Buildroot] [PATCH 2/4] toolchain/helpers.mk: re-evaluate DESTDIR in copy_toolchain_lib_root Thomas Petazzoni
2017-07-02 13:41 ` [Buildroot] [PATCH 3/4] toolchain-external: copy ld*.so* for all C libraries Thomas Petazzoni
2017-07-02 13:49   ` Baruch Siach
2017-07-02 19:21   ` Thomas De Schampheleire
2017-07-02 21:51     ` Thomas Petazzoni [this message]
2017-07-02 13:41 ` [Buildroot] [PATCH 4/4] toolchain-external: also put libgcc_s.so unconditionally in TOOLCHAIN_EXTERNAL_LIBS Thomas Petazzoni
2017-07-05 10:24 ` [Buildroot] [PATCH 0/4] Solving the musl dynamic linker issues Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170702235127.14b7ca48@windsurf \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.