From: Jiri Benc <jbenc@redhat.com>
To: Waiman Long <longman@redhat.com>
Cc: netdev@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>,
pravin shelar <pshelar@ovn.org>
Subject: Re: [PATCH net 1/2] vxlan: fix hlist corruption
Date: Mon, 3 Jul 2017 10:23:59 +0200 [thread overview]
Message-ID: <20170703102359.246d68a2@griffin> (raw)
In-Reply-To: <38e4eb5a-2d9e-4f38-f043-42a1dd449bfb@redhat.com>
On Sun, 2 Jul 2017 16:06:10 -0400, Waiman Long wrote:
> I didn't see any init code for hlist4 and hlist6. Is vxlan_dev going to
> be *zalloc'ed so that they are guaranteed to be NULL? If not, you may
> need to add init code as not both hlists will be hashed and so one of
> them may contain invalid data.
Yes, it's zalloced via alloc_netdev. No need to init the fields
explicitly.
Jiri
next prev parent reply other threads:[~2017-07-03 8:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-02 17:00 [PATCH net 0/2] vxlan, geneve: fix hlist corruption Jiri Benc
2017-07-02 17:00 ` [PATCH net 1/2] vxlan: " Jiri Benc
2017-07-02 20:06 ` Waiman Long
2017-07-03 8:23 ` Jiri Benc [this message]
2017-07-03 13:25 ` Waiman Long
2017-07-02 17:00 ` [PATCH net 2/2] geneve: " Jiri Benc
2017-07-03 9:37 ` [PATCH net 0/2] vxlan, " David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170703102359.246d68a2@griffin \
--to=jbenc@redhat.com \
--cc=linville@tuxdriver.com \
--cc=longman@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pshelar@ovn.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.