From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
To: "Van Haaren, Harry" <harry.van.haaren@intel.com>
Cc: "olivier.matz@6wind.com" <olivier.matz@6wind.com>,
"Richardson, Bruce" <bruce.richardson@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [PATCH v2 5/5] event/sw: change worker rings to standard event rings
Date: Tue, 4 Jul 2017 11:06:23 +0530 [thread overview]
Message-ID: <20170704053622.GA14375@jerin> (raw)
In-Reply-To: <E923DB57A917B54B9182A2E928D00FA640C35B2C@IRSMSX102.ger.corp.intel.com>
-----Original Message-----
> Date: Mon, 3 Jul 2017 13:01:47 +0000
> From: "Van Haaren, Harry" <harry.van.haaren@intel.com>
> To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> CC: "olivier.matz@6wind.com" <olivier.matz@6wind.com>, "Richardson, Bruce"
> <bruce.richardson@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
> Subject: RE: [dpdk-dev] [PATCH v2 5/5] event/sw: change worker rings to
> standard event rings
>
> > rings
> > > >
> > > > Now that we have a standard event ring implementation for passing events
> > > > core-to-core, use that in place of the custom event rings in the software
> > > > eventdev.
> > > >
> > > > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > >
> > > Agree with 99% of this patch, but due to the implementation (with memzone lookup),
> > > we need to change one part of the sw_port_setup() function.
> > >
> > > The change is required to allow port_setup() to be called multiple times on the same
> > > port, which is required to re-configure a port that has already been configured once.
> > >
> > > I can send a separate fix, or I could re-spin Bruce's 5 patches, and include the fix.
> > >
> > > Given this is a small, non-datapath modification to the SW PMD, my preference is to
> > > ack this patch once I've posted a separate patch fix for the SW PMD.
> > >
> > > @Jerin, any preference?
> >
> > I think, you can send it as a separate patch. I can squash the fix patch with this
> > patch or apply it as separate one if you are not concerned about
> > breaking when we do "git bisect". Let me know.
>
> Can be squashed then, please and thanks!
>
> Then this patch itself (5/5) is
>
> Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
Applied this series to dpdk-next-eventdev/master after squashing
http://dpdk.org/dev/patchwork/patch/26241/
Thanks
prev parent reply other threads:[~2017-07-04 5:36 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-07 13:36 [PATCH 0/5] create event rings type Bruce Richardson
2017-06-07 13:36 ` [PATCH 1/5] ring: allow rings with non power-of-2 sizes Bruce Richardson
2017-06-30 9:40 ` Olivier Matz
2017-06-30 11:32 ` Bruce Richardson
2017-06-30 12:24 ` Olivier Matz
2017-06-30 13:59 ` Bruce Richardson
2017-06-07 13:36 ` [PATCH 2/5] test/test: add unit tests for exact size rings Bruce Richardson
2017-06-30 9:42 ` Olivier Matz
2017-06-07 13:36 ` [PATCH 3/5] eventdev: add ring structure for events Bruce Richardson
2017-06-12 5:15 ` Jerin Jacob
2017-06-12 8:53 ` Bruce Richardson
2017-06-30 13:24 ` Bruce Richardson
2017-06-07 13:36 ` [PATCH 4/5] test/test: add auto-tests for event ring functions Bruce Richardson
2017-06-07 13:36 ` [PATCH 5/5] event/sw: change worker rings to standard event rings Bruce Richardson
2017-06-30 15:06 ` [PATCH v2 0/5] create event rings type Bruce Richardson
2017-06-30 15:06 ` [PATCH v2 1/5] ring: allow rings with non power-of-2 sizes Bruce Richardson
2017-07-03 8:46 ` Olivier Matz
2017-06-30 15:06 ` [PATCH v2 2/5] test/test: add unit tests for exact size rings Bruce Richardson
2017-07-03 8:47 ` Olivier Matz
2017-06-30 15:06 ` [PATCH v2 3/5] eventdev: add ring structure for events Bruce Richardson
2017-07-03 9:52 ` Van Haaren, Harry
2017-06-30 15:06 ` [PATCH v2 4/5] test/test: add auto-tests for event ring functions Bruce Richardson
2017-07-03 12:30 ` Van Haaren, Harry
2017-06-30 15:06 ` [PATCH v2 5/5] event/sw: change worker rings to standard event rings Bruce Richardson
2017-07-03 12:28 ` Van Haaren, Harry
2017-07-03 12:44 ` Jerin Jacob
2017-07-03 13:01 ` Van Haaren, Harry
2017-07-04 5:36 ` Jerin Jacob [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170704053622.GA14375@jerin \
--to=jerin.jacob@caviumnetworks.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=harry.van.haaren@intel.com \
--cc=olivier.matz@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.