From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54549) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dSMo6-000320-Bd for qemu-devel@nongnu.org; Tue, 04 Jul 2017 08:19:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dSMo5-000248-Ch for qemu-devel@nongnu.org; Tue, 04 Jul 2017 08:19:54 -0400 Date: Tue, 4 Jul 2017 13:19:42 +0100 From: "Daniel P. Berrange" Message-ID: <20170704121942.GL3135@redhat.com> Reply-To: "Daniel P. Berrange" References: <20170704103427.22791-1-berrange@redhat.com> <20170704121606.GE4253@noname.str.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20170704121606.GE4253@noname.str.redhat.com> Subject: Re: [Qemu-devel] [PATCH] qemu-img: delete the -e and -6 options from the 'create' command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, Max Reitz On Tue, Jul 04, 2017 at 02:16:06PM +0200, Kevin Wolf wrote: > Am 04.07.2017 um 12:34 hat Daniel P. Berrange geschrieben: > > The '-e' and '-6' options to the 'create' command were "deprecated" > > in favour of the more generic '-o' option many years ago: > > > > commit eec77d9e712bd4157a4e1c0b5a9249d168add738 > > Author: Jes Sorensen > > Date: Tue Dec 7 17:44:34 2010 +0100 > > > > qemu-img: Deprecate obsolete -6 and -e options > > > > Except this was never actually a deprecation, which would imply giving > > the user a warning while the functionality continues to work for a > > number of releases before eventual removal. Instead the options were > > immediately turned into an error + exit. Given that the functionality > > is already broken, there's no point in keeping these psuedo-deprecation > > messages around any longer. > > > > Signed-off-by: Daniel P. Berrange > > Thanks, applied to the block branch. > > Do you want to send another patch to do the same in qemu-img convert? Opps, I wasn't paying attention & missed the convert command. I'll just send a v2 of this that covers both. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|