From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: EDAC: remove unnecessary static in edac_fake_inject_write() From: "Gustavo A. R. Silva" Message-Id: <20170704214440.GA9462@embeddedgus> Date: Tue, 4 Jul 2017 16:44:40 -0500 To: Borislav Petkov , Mauro Carvalho Chehab Cc: linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" List-ID: UmVtb3ZlIHVubmVjZXNzYXJ5IHN0YXRpYyBvbiBsb2NhbCB2YXJpYWJsZSBfdHlwZV8uClN1Y2gg dmFyaWFibGUgaXMgaW5pdGlhbGl6ZWQgYmVmb3JlIGJlaW5nIHVzZWQsCm9uIGV2ZXJ5IGV4ZWN1 dGlvbiBwYXRoIHRocm91Z2hvdXQgdGhlIGZ1bmN0aW9uLgpUaGUgc3RhdGljIGhhcyBubyBiZW5l Zml0IGFuZCwgcmVtb3ZpbmcgaXQgcmVkdWNlcwp0aGUgY29kZSBzaXplLgoKVGhpcyBpc3N1ZSB3 YXMgZGV0ZWN0ZWQgdXNpbmcgQ29jY2luZWxsZSBhbmQgdGhlIGZvbGxvd2luZyBzZW1hbnRpYyBw YXRjaDoKCkBiYWQgZXhpc3RzQApwb3NpdGlvbiBwOwppZGVudGlmaWVyIHg7CnR5cGUgVDsKQEAK CnN0YXRpYyBUIHhAcDsKLi4uCnggPSA8Ky4uLnguLi4rPgoKQEAKaWRlbnRpZmllciB4OwpleHBy ZXNzaW9uIGU7CnR5cGUgVDsKcG9zaXRpb24gcCAhPSBiYWQucDsKQEAKCi1zdGF0aWMKIFQgeEBw OwogLi4uIHdoZW4gIT0geAogICAgIHdoZW4gc3RyaWN0Cj94ID0gZTsKCkluIHRoZSBmb2xsb3dp bmcgbG9nIHlvdSBjYW4gc2VlIHRoZSBkaWZmZXJlbmNlIGluIHRoZSBjb2RlIHNpemUgYW5kLAph bHNvIGEgc2lnbmlmaWNhbnQgZGlmZmVyZW5jZSBpbiBic3Mgc2VnbWVudC4gVGhpcyBsb2cgaXMg dGhlIG91dHB1dApvZiB0aGUgc2l6ZSBjb21tYW5kLCBiZWZvcmUgYW5kIGFmdGVyIHRoZSBjb2Rl IGNoYW5nZToKCmJlZm9yZToKICAgdGV4dCAgICBkYXRhICAgICBic3MgICAgIGRlYyAgICAgaGV4 IGZpbGVuYW1lCiAgIDI5NjYgICAgIDkyMCAgICAgMTI4ICAgIDQwMTQgICAgIGZhZSBkcml2ZXJz L2VkYWMvZGVidWdmcy5vCgphZnRlcjoKICAgdGV4dCAgICAgZGF0YSAgICAgYnNzICAgIGRlYyAg ICAgaGV4IGZpbGVuYW1lCiAgIDI5NjEgICAgIDgzMiAgICAgIDY0ICAgIDM4NTcgICAgIGYxMSBk cml2ZXJzL2VkYWMvZGVidWdmcy5vCgpTaWduZWQtb2ZmLWJ5OiBHdXN0YXZvIEEuIFIuIFNpbHZh IDxnYXJzaWx2YUBlbWJlZGRlZG9yLmNvbT4KLS0tCiBkcml2ZXJzL2VkYWMvZGVidWdmcy5jIHwg MiArLQogMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZm IC0tZ2l0IGEvZHJpdmVycy9lZGFjL2RlYnVnZnMuYyBiL2RyaXZlcnMvZWRhYy9kZWJ1Z2ZzLmMK aW5kZXggOTJkYmI3ZS4uYmEwYWY0OSAxMDA2NDQKLS0tIGEvZHJpdmVycy9lZGFjL2RlYnVnZnMu YworKysgYi9kcml2ZXJzL2VkYWMvZGVidWdmcy5jCkBAIC04LDcgKzgsNyBAQCBzdGF0aWMgc3Np emVfdCBlZGFjX2Zha2VfaW5qZWN0X3dyaXRlKHN0cnVjdCBmaWxlICpmaWxlLAogewogCXN0cnVj dCBkZXZpY2UgKmRldiA9IGZpbGUtPnByaXZhdGVfZGF0YTsKIAlzdHJ1Y3QgbWVtX2N0bF9pbmZv ICptY2kgPSB0b19tY2koZGV2KTsKLQlzdGF0aWMgZW51bSBod19ldmVudF9tY19lcnJfdHlwZSB0 eXBlOworCWVudW0gaHdfZXZlbnRfbWNfZXJyX3R5cGUgdHlwZTsKIAl1MTYgZXJyY291bnQgPSBt Y2ktPmZha2VfaW5qZWN0X2NvdW50OwogCiAJaWYgKCFlcnJjb3VudCkK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753827AbdGDWIm (ORCPT ); Tue, 4 Jul 2017 18:08:42 -0400 Received: from gateway36.websitewelcome.com ([192.185.201.2]:23149 "EHLO gateway36.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752257AbdGDWIl (ORCPT ); Tue, 4 Jul 2017 18:08:41 -0400 X-Greylist: delayed 1438 seconds by postgrey-1.27 at vger.kernel.org; Tue, 04 Jul 2017 18:08:41 EDT Date: Tue, 4 Jul 2017 16:44:40 -0500 From: "Gustavo A. R. Silva" To: Borislav Petkov , Mauro Carvalho Chehab Cc: linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" Subject: [PATCH] EDAC: remove unnecessary static in edac_fake_inject_write() Message-ID: <20170704214440.GA9462@embeddedgus> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.152.164.199 X-Exim-ID: 1dSVcf-002SBx-6R X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: (embeddedgus) [189.152.164.199]:45378 X-Source-Auth: garsilva@embeddedor.com X-Email-Count: 10 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Remove unnecessary static on local variable _type_. Such variable is initialized before being used, on every execution path throughout the function. The static has no benefit and, removing it reduces the code size. This issue was detected using Coccinelle and the following semantic patch: @bad exists@ position p; identifier x; type T; @@ static T x@p; ... x = <+...x...+> @@ identifier x; expression e; type T; position p != bad.p; @@ -static T x@p; ... when != x when strict ?x = e; In the following log you can see the difference in the code size and, also a significant difference in bss segment. This log is the output of the size command, before and after the code change: before: text data bss dec hex filename 2966 920 128 4014 fae drivers/edac/debugfs.o after: text data bss dec hex filename 2961 832 64 3857 f11 drivers/edac/debugfs.o Signed-off-by: Gustavo A. R. Silva --- drivers/edac/debugfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/edac/debugfs.c b/drivers/edac/debugfs.c index 92dbb7e..ba0af49 100644 --- a/drivers/edac/debugfs.c +++ b/drivers/edac/debugfs.c @@ -8,7 +8,7 @@ static ssize_t edac_fake_inject_write(struct file *file, { struct device *dev = file->private_data; struct mem_ctl_info *mci = to_mci(dev); - static enum hw_event_mc_err_type type; + enum hw_event_mc_err_type type; u16 errcount = mci->fake_inject_count; if (!errcount) -- 2.5.0