From: Stephen Hemminger <stephen@networkplumber.org>
To: Krister Johansen <kjlx@templeofstupid.com>
Cc: netdev@vger.kernel.org, simon.horman@netronome.com, dsahern@gmail.com
Subject: Re: [PATCH iproute/master 0/3] lost mpls ip tunnel patches
Date: Wed, 5 Jul 2017 09:06:50 -0700 [thread overview]
Message-ID: <20170705090650.6598846d@xeon-e3> (raw)
In-Reply-To: <1497058292-10099-1-git-send-email-kjlx@templeofstupid.com>
On Fri, 9 Jun 2017 18:31:29 -0700
Krister Johansen <kjlx@templeofstupid.com> wrote:
> Hi Stephen,
> I'm a bit unsure of the decorum in this particular situation. Kernel
> support for mpls/ip tunnels was integrated back in July of 2016. At the
> time, the author of that feature sent out a RFC patch for the iproute
> support but never followed up on subsequent code review comments.
>
> The kernel support got merged, but the iproute support never made it in.
> I wanted to run some tests with these features. In the process, I
> tracked down the author's original patches, merged them into current
> iproute, and attempted to address the comments from code reviewers.
>
> I've attached an 'Original-Author' label to each commit, and have CC'd
> him and the code reviewer on this patch. If any part of this is
> improper, please let me know and I'll respin accordingly. Mostly, I
> wanted to close the loop here so the mpls in ip tunnel support is usable
> through iproute.
>
> The original threads for the 2016 patch are here:
>
> http://marc.info/?l=linux-netdev&m=146782946216005&w=2
> http://marc.info/?l=linux-netdev&m=146782941615977&w=2
> http://marc.info/?l=linux-netdev&m=146782947016007&w=2
> http://marc.info/?l=linux-netdev&m=146782942915988&w=2
>
> Thanks,
>
> -K
>
> Krister Johansen (3):
> iptunnel: document mode parameter for sit tunnels
> iptunnel: add support for mpls/ip to sit tunnels
> iptunnel: add support for mpls/ip to ipip tunnels
>
> include/utils.h | 3 +++
> ip/link_iptnl.c | 30 ++++++++++++++++++++++++++----
> ip/tunnel.c | 3 +++
> man/man8/ip-link.8.in | 12 +++++++++++-
> 4 files changed, 43 insertions(+), 5 deletions(-)
>
I went ahead and merged these in. Would be better to get the headers
stuff straightened out but that is probably an endless battle.
prev parent reply other threads:[~2017-07-05 16:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-10 1:31 [PATCH iproute/master 0/3] lost mpls ip tunnel patches Krister Johansen
2017-06-10 1:31 ` [PATCH iproute/master 1/3] iptunnel: document mode parameter for sit tunnels Krister Johansen
2017-06-10 1:31 ` [PATCH iproute/master 2/3] iptunnel: add support for mpls/ip to " Krister Johansen
2017-06-14 17:02 ` Stephen Hemminger
2017-06-14 17:11 ` Krister Johansen
2017-06-14 17:16 ` David Ahern
2017-06-15 18:31 ` Krister Johansen
2017-06-10 1:31 ` [PATCH iproute/master 3/3] iptunnel: add support for mpls/ip to ipip tunnels Krister Johansen
2017-06-14 17:24 ` [PATCH iproute/master 0/3] lost mpls ip tunnel patches Stephen Hemminger
2017-06-14 17:33 ` Krister Johansen
2017-07-05 16:06 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170705090650.6598846d@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=dsahern@gmail.com \
--cc=kjlx@templeofstupid.com \
--cc=netdev@vger.kernel.org \
--cc=simon.horman@netronome.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.