All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v6 1/2] fs/ext2: rename BR2_TARGET_ROOTFS_EXT2_BLOCKS -> BR2_TARGET_ROOTFS_EXT2_SIZE
Date: Wed, 5 Jul 2017 16:30:49 +0200	[thread overview]
Message-ID: <20170705163049.56337a21@windsurf> (raw)
In-Reply-To: <20170705130750.c3ilmo52bakld4cf@tarshish>

Hello,

On Wed, 5 Jul 2017 16:07:50 +0300, Baruch Siach wrote:

> > +config BR2_TARGET_ROOTFS_EXT2_BLOCKS
> > +	int "exact size in blocks has been removed"
> > +	default 0  
> 
> Missing BR2_LEGACY.

No, because it's an int option. It's the ..._WRAP option below that
selects BR2_LEGACY.

> > +	help
> > +	  This option has been removed in favor of BR2_TARGET_ROOTFS_EXT2_SIZE.
> > +	  It has been set automatically to the value you had before.
> > +
> > +config BR2_TARGET_ROOTFS_EXT2_BLOCKS_WRAP
> > +	bool
> > +	default y if BR2_TARGET_ROOTFS_EXT2_BLOCKS != 0
> > +	default y if BR2_TARGET_ROOTFS_EXT2_BLOCKS != 61440 # deprecated default value
> > +	select BR2_LEGACY
> > +
> > +# Note: BR2_TARGET_ROOTFS_EXT2_BLOCKS_WRAP still reference in fs/ext2/Config.in  

See the big comment at the top of Config.in.legacy for details about
why we're doing it like that.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

      reply	other threads:[~2017-07-05 14:30 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-05 13:00 [Buildroot] [PATCH v6 1/2] fs/ext2: rename BR2_TARGET_ROOTFS_EXT2_BLOCKS -> BR2_TARGET_ROOTFS_EXT2_SIZE Samuel Martin
2017-07-05 13:01 ` [Buildroot] [PATCH v6 2/2] fs/ext2: Add BR2_TARGET_ROOTFS_EXT2_MKFS_OPTIONS option Samuel Martin
2017-07-05 13:09   ` Baruch Siach
2017-07-05 13:13     ` Yann E. MORIN
2017-07-05 13:19       ` Baruch Siach
2017-07-05 13:07 ` [Buildroot] [PATCH v6 1/2] fs/ext2: rename BR2_TARGET_ROOTFS_EXT2_BLOCKS -> BR2_TARGET_ROOTFS_EXT2_SIZE Baruch Siach
2017-07-05 14:30   ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170705163049.56337a21@windsurf \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.