From: mjg59@srcf.ucam.org (Matthew Garrett)
To: linux-security-module@vger.kernel.org
Subject: [PATCH v2 10/10] ima: use existing read file operation method to calculate file hash
Date: Wed, 5 Jul 2017 18:02:15 +0100 [thread overview]
Message-ID: <20170705170215.GA14148@srcf.ucam.org> (raw)
In-Reply-To: <1499266209.3059.91.camel@linux.vnet.ibm.com>
On Wed, Jul 05, 2017 at 10:50:09AM -0400, Mimi Zohar wrote:
> [Cc'ing linux-ima-users]
>
> On Wed, 2017-06-28 at 16:41 +0200, Christoph Hellwig wrote:
> > NAK - we'll need an explicit method for the integrity code.
> >
> > And just curious - what filesystem that you care about actually
> > implements ->read instead of ->read_iter? We shouldn't be doing that
> > for real file systems anymore.
>
> Right, pseudo filesystems are using ->read. The existing builtin
> measurement policies exclude a number of pseudo filesystems, but not
> efivarfs. ?Unfortunately, we do not know what type of custom policies
> are currently being used.
efi variables contain information that may influence userspace behaviour
and can also be modified out of band, so I think there's a reasonable
argument that they should be measured.
--
Matthew Garrett | mjg59 at srcf.ucam.org
--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Mimi Zohar <zohar@linux.vnet.ibm.com>
Cc: Christoph Hellwig <hch@lst.de>, Al Viro <viro@zeniv.linux.org.uk>,
James Morris <jmorris@namei.org>,
linux-fsdevel@vger.kernel.org,
linux-ima-devel@lists.sourceforge.net,
linux-security-module@vger.kernel.org,
linux-ima-user <linux-ima-user@lists.sourceforge.net>
Subject: Re: [PATCH v2 10/10] ima: use existing read file operation method to calculate file hash
Date: Wed, 5 Jul 2017 18:02:15 +0100 [thread overview]
Message-ID: <20170705170215.GA14148@srcf.ucam.org> (raw)
In-Reply-To: <1499266209.3059.91.camel@linux.vnet.ibm.com>
On Wed, Jul 05, 2017 at 10:50:09AM -0400, Mimi Zohar wrote:
> [Cc'ing linux-ima-users]
>
> On Wed, 2017-06-28 at 16:41 +0200, Christoph Hellwig wrote:
> > NAK - we'll need an explicit method for the integrity code.
> >
> > And just curious - what filesystem that you care about actually
> > implements ->read instead of ->read_iter? We shouldn't be doing that
> > for real file systems anymore.
>
> Right, pseudo filesystems are using ->read. The existing builtin
> measurement policies exclude a number of pseudo filesystems, but not
> efivarfs. �Unfortunately, we do not know what type of custom policies
> are currently being used.
efi variables contain information that may influence userspace behaviour
and can also be modified out of band, so I think there's a reasonable
argument that they should be measured.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2017-07-05 17:02 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-21 18:18 [PATCH v2 00/10] define new fs integrity_read method Mimi Zohar
2017-06-21 18:18 ` Mimi Zohar
2017-06-21 18:18 ` [PATCH v2 01/10] ima: always measure and audit files in policy Mimi Zohar
2017-06-21 18:18 ` Mimi Zohar
2017-06-21 18:18 ` [PATCH v2 02/10] ima: use fs method to read integrity data Mimi Zohar
2017-06-21 18:18 ` Mimi Zohar
2017-06-28 14:38 ` Christoph Hellwig
2017-06-28 14:38 ` Christoph Hellwig
2017-06-21 18:18 ` [PATCH v2 03/10] ima: define "dont_failsafe" policy action rule Mimi Zohar
2017-06-21 18:18 ` Mimi Zohar
2017-06-21 18:18 ` [PATCH v2 04/10] ima: define "fs_unsafe" builtin policy Mimi Zohar
2017-06-21 18:18 ` Mimi Zohar
2017-06-21 18:18 ` [PATCH v2 05/10] tmpfs: define integrity_read method Mimi Zohar
2017-06-21 18:18 ` Mimi Zohar
2017-06-28 14:38 ` Christoph Hellwig
2017-06-28 14:38 ` Christoph Hellwig
2017-07-06 11:55 ` Mimi Zohar
2017-07-06 11:55 ` Mimi Zohar
2017-07-06 11:55 ` Mimi Zohar
2017-06-21 18:18 ` [PATCH v2 06/10] fs: define integrity_read method for ext2, gfs2, f2fs, jfs, ramfs Mimi Zohar
2017-06-21 18:18 ` Mimi Zohar
2017-06-28 14:39 ` Christoph Hellwig
2017-06-28 14:39 ` Christoph Hellwig
2017-06-21 18:18 ` [PATCH v2 07/10] ocfs2: define integrity_read method Mimi Zohar
2017-06-21 18:18 ` Mimi Zohar
2017-06-21 18:18 ` [Ocfs2-devel] " Mimi Zohar
2017-06-28 14:39 ` Christoph Hellwig
2017-06-28 14:39 ` Christoph Hellwig
2017-06-28 14:39 ` [Ocfs2-devel] " Christoph Hellwig
2017-06-21 18:18 ` [PATCH v2 08/10] jffs2: " Mimi Zohar
2017-06-21 18:18 ` Mimi Zohar
2017-06-28 14:39 ` Christoph Hellwig
2017-06-28 14:39 ` Christoph Hellwig
2017-06-21 18:18 ` [PATCH v2 09/10] ubifs: " Mimi Zohar
2017-06-21 18:18 ` Mimi Zohar
2017-06-28 14:39 ` Christoph Hellwig
2017-06-28 14:39 ` Christoph Hellwig
2017-06-21 18:18 ` [PATCH v2 10/10] ima: use existing read file operation method to calculate file hash Mimi Zohar
2017-06-21 18:18 ` Mimi Zohar
2017-06-28 14:41 ` Christoph Hellwig
2017-06-28 14:41 ` Christoph Hellwig
2017-07-05 14:50 ` Mimi Zohar
2017-07-05 14:50 ` Mimi Zohar
2017-07-05 17:02 ` Matthew Garrett [this message]
2017-07-05 17:02 ` Matthew Garrett
2017-07-05 17:18 ` Christoph Hellwig
2017-07-05 17:18 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170705170215.GA14148@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=linux-security-module@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.