From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v1] qt5multimedia: fix plugins videonode egl x11 header related compile failure
Date: Wed, 5 Jul 2017 22:03:26 +0200 [thread overview]
Message-ID: <20170705220326.0f121c3a@windsurf> (raw)
In-Reply-To: <20170705215319.42939a87@gmx.net>
Hello,
On Wed, 5 Jul 2017 21:53:19 +0200, Peter Seiderer wrote:
> > > but in general your are right, honor the given provider provided flags would be
> > > the better solution...maybe something as suggested on the yocto meta-freescale
> > > mailing list will work, see [2], [3]: 'egl.prf: Fix build error when egl headers
> > > need platform definition'?
>
> And two links to the upstream suggestion/discussion:
>
> - QTBUG-61712: qtbase: A build error was occurring due to missing EGL configuration
> https://bugreports.qt.io/browse/QTBUG-61712
>
> - Patch: qtbase: Fix build error when using EGL
> https://codereview.qt-project.org/#/c/198906/
I'm not used to the Qt contribution workflow, but the patch visible
through those links looks good (use CFLAGS provided by the EGL .pc
file), and the reception seems positive (+6 votes on the code review
tool).
So it all seems to be going in the right direction, no?
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
prev parent reply other threads:[~2017-07-05 20:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-26 21:13 [Buildroot] [PATCH v1] qt5multimedia: fix plugins videonode egl x11 header related compile failure Peter Seiderer
2017-07-01 22:33 ` Thomas Petazzoni
2017-07-02 19:01 ` Peter Seiderer
2017-07-02 21:14 ` Thomas Petazzoni
2017-07-03 18:46 ` Peter Seiderer
2017-07-03 19:02 ` Thomas Petazzoni
2017-07-05 19:53 ` Peter Seiderer
2017-07-05 20:03 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170705220326.0f121c3a@windsurf \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.