All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jaegeuk Kim <jaegeuk@kernel.org>
To: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net
Cc: Jaegeuk Kim <jaegeuk@kernel.org>
Subject: [PATCH] f2fs: relax permission for atomic/volatile ioctls
Date: Wed,  5 Jul 2017 19:23:26 -0700	[thread overview]
Message-ID: <20170706022326.52594-1-jaegeuk@kernel.org> (raw)

This patch allows atomic/volatile ioctls for sqlite under sdcardfs.

Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
---
 fs/f2fs/file.c | 15 ---------------
 1 file changed, 15 deletions(-)

diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
index f5d6357e8360..dd8f5d2caa48 100644
--- a/fs/f2fs/file.c
+++ b/fs/f2fs/file.c
@@ -1587,9 +1587,6 @@ static int f2fs_ioc_start_atomic_write(struct file *filp)
 	struct inode *inode = file_inode(filp);
 	int ret;
 
-	if (!inode_owner_or_capable(inode))
-		return -EACCES;
-
 	if (!S_ISREG(inode->i_mode))
 		return -EINVAL;
 
@@ -1636,9 +1633,6 @@ static int f2fs_ioc_commit_atomic_write(struct file *filp)
 	struct inode *inode = file_inode(filp);
 	int ret;
 
-	if (!inode_owner_or_capable(inode))
-		return -EACCES;
-
 	ret = mnt_want_write_file(filp);
 	if (ret)
 		return ret;
@@ -1672,9 +1666,6 @@ static int f2fs_ioc_start_volatile_write(struct file *filp)
 	struct inode *inode = file_inode(filp);
 	int ret;
 
-	if (!inode_owner_or_capable(inode))
-		return -EACCES;
-
 	if (!S_ISREG(inode->i_mode))
 		return -EINVAL;
 
@@ -1707,9 +1698,6 @@ static int f2fs_ioc_release_volatile_write(struct file *filp)
 	struct inode *inode = file_inode(filp);
 	int ret;
 
-	if (!inode_owner_or_capable(inode))
-		return -EACCES;
-
 	ret = mnt_want_write_file(filp);
 	if (ret)
 		return ret;
@@ -1736,9 +1724,6 @@ static int f2fs_ioc_abort_volatile_write(struct file *filp)
 	struct inode *inode = file_inode(filp);
 	int ret;
 
-	if (!inode_owner_or_capable(inode))
-		return -EACCES;
-
 	ret = mnt_want_write_file(filp);
 	if (ret)
 		return ret;
-- 
2.13.0.rc1.294.g07d810a77f-goog

             reply	other threads:[~2017-07-06  2:23 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-06  2:23 Jaegeuk Kim [this message]
2017-07-07  0:04 ` [PATCH] f2fs: relax permission for atomic/volatile ioctls Chao Yu
2017-07-07  0:04   ` [f2fs-dev] " Chao Yu
2017-07-07  0:16   ` Jaegeuk Kim
2017-07-07  0:16     ` [f2fs-dev] " Jaegeuk Kim
2017-07-07  0:58     ` Chao Yu
2017-07-07  1:19       ` 答复: " gaoxiang (P)
2017-07-07  2:12         ` 答复: [f2fs-dev] " Jaegeuk Kim
2017-07-07  2:19           ` 答复: " gaoxiang (P)
2017-07-07  2:19             ` 答复: [f2fs-dev] " gaoxiang (P)
2017-07-07  2:08 ` Eric Biggers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170706022326.52594-1-jaegeuk@kernel.org \
    --to=jaegeuk@kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.