From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>
Subject: [PATCH 1/3] eal: simplify finding starting point
Date: Thu, 6 Jul 2017 08:28:10 -0700 [thread overview]
Message-ID: <20170706152812.16072-2-stephen@networkplumber.org> (raw)
In-Reply-To: <20170706152812.16072-1-stephen@networkplumber.org>
A separate boolean variable is not necessary when searching for
starting point in find_device. Just use the passed argument
as its own flag value.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
lib/librte_eal/common/eal_common_bus.c | 6 ++----
lib/librte_eal/common/eal_common_pci.c | 6 ++----
lib/librte_eal/common/eal_common_vdev.c | 6 ++----
3 files changed, 6 insertions(+), 12 deletions(-)
diff --git a/lib/librte_eal/common/eal_common_bus.c b/lib/librte_eal/common/eal_common_bus.c
index 87b0c6e6fa03..997009d2b8d0 100644
--- a/lib/librte_eal/common/eal_common_bus.c
+++ b/lib/librte_eal/common/eal_common_bus.c
@@ -154,12 +154,10 @@ rte_bus_find(const struct rte_bus *start, rte_bus_cmp_t cmp,
const void *data)
{
struct rte_bus *bus = NULL;
- bool start_found = !start;
TAILQ_FOREACH(bus, &rte_bus_list, next) {
- if (!start_found) {
- if (bus == start)
- start_found = 1;
+ if (start && bus == start) {
+ start = NULL; /* starting point found */
continue;
}
if (cmp(bus, data) == 0)
diff --git a/lib/librte_eal/common/eal_common_pci.c b/lib/librte_eal/common/eal_common_pci.c
index 5ee100e67374..7ed259b09cd0 100644
--- a/lib/librte_eal/common/eal_common_pci.c
+++ b/lib/librte_eal/common/eal_common_pci.c
@@ -491,12 +491,10 @@ pci_find_device(const struct rte_device *start, rte_dev_cmp_t cmp,
const void *data)
{
struct rte_pci_device *dev;
- bool start_found = !start;
FOREACH_DEVICE_ON_PCIBUS(dev) {
- if (!start_found) {
- if (&dev->device == start)
- start_found = 1;
+ if (start && &dev->device == start) {
+ start = NULL; /* starting point found */
continue;
}
if (cmp(&dev->device, data) == 0)
diff --git a/lib/librte_eal/common/eal_common_vdev.c b/lib/librte_eal/common/eal_common_vdev.c
index baf3c5bfa23f..9ec62f4d4dea 100644
--- a/lib/librte_eal/common/eal_common_vdev.c
+++ b/lib/librte_eal/common/eal_common_vdev.c
@@ -342,12 +342,10 @@ vdev_find_device(const struct rte_device *start, rte_dev_cmp_t cmp,
const void *data)
{
struct rte_vdev_device *dev;
- bool start_found = !start;
TAILQ_FOREACH(dev, &vdev_device_list, next) {
- if (start_found == 0) {
- if (&dev->device == start)
- start_found = 1;
+ if (start && &dev->device == start) {
+ start = NULL;
continue;
}
if (cmp(&dev->device, data) == 0)
--
2.11.0
next prev parent reply other threads:[~2017-07-06 15:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-06 15:28 [PATCH 0/3] eal: minor cleanups Stephen Hemminger
2017-07-06 15:28 ` Stephen Hemminger [this message]
2017-07-06 15:28 ` [PATCH 2/3] fslmc: simplfy find_device Stephen Hemminger
2017-07-06 15:28 ` [PATCH 3/3] eal: fix spelling in comment Stephen Hemminger
2017-07-08 17:29 ` [PATCH 0/3] eal: minor cleanups Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170706152812.16072-2-stephen@networkplumber.org \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.