From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] webkitgtk: select libgcrypt
Date: Thu, 6 Jul 2017 23:25:40 +0200 [thread overview]
Message-ID: <20170706232540.4c9a2425@windsurf.lan> (raw)
In-Reply-To: <20170705194653.19890-2-aperez@igalia.com>
Hello,
On Wed, 5 Jul 2017 22:46:53 +0300, Adrian Perez de Castro wrote:
> Libgrcrypt is a direct dependency of WebKitGTK+, and as such it
> should be selected.
>
> Signed-off-by: Adrian Perez de Castro <aperez@igalia.com>
> ---
> package/webkitgtk/Config.in | 1 +
> package/webkitgtk/webkitgtk.mk | 2 +-
> 2 files changed, 2 insertions(+), 1 deletion(-)
When you select a package, you must replicate its dependencies. So in
this case, when you add "select BR2_PACKAGE_LIBGCRYPT", you must add
"depends on BR2_PACKAGE_LIBGPG_ERROR_ARCH_SUPPORTS".
Of course, the set of architectures supported by WebKitGTK+ is probably
already smaller than the set of architectures supported by
libgpg-error, but for consistency reasons, replicating the dependency
is recommended.
I've applied your patch after addressing this issue. Thanks a lot!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-07-06 21:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-05 19:46 [Buildroot] [PATCH 0/1] Select libgcrypt along with webkitgtk Adrian Perez de Castro
2017-07-05 19:46 ` [Buildroot] [PATCH 1/1] webkitgtk: select libgcrypt Adrian Perez de Castro
2017-07-05 20:23 ` Arnout Vandecappelle
2017-07-06 21:25 ` Thomas Petazzoni [this message]
2017-07-19 14:05 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170706232540.4c9a2425@windsurf.lan \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.