All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 3/3] mtd: be explicit about config options for the host
Date: Fri, 7 Jul 2017 10:02:18 +0200	[thread overview]
Message-ID: <20170707100218.09e408c0@windsurf.lan> (raw)
In-Reply-To: <b44bd05b-2ba9-d91a-803a-bb35cf4be5ee@mind.be>

Hello,

On Fri, 7 Jul 2017 00:57:59 +0200, Arnout Vandecappelle wrote:
> On 06-07-17 22:58, Thomas Petazzoni wrote:
> > Instead of letting auto-detection do its job, be explicit about the
> > fact that we want the JFFS2 and UBIFS utilities when building the host
> > variant of mtd.
> > 
> > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> > ---
> >  package/mtd/mtd.mk | 5 ++++-
> >  1 file changed, 4 insertions(+), 1 deletion(-)
> > 
> > diff --git a/package/mtd/mtd.mk b/package/mtd/mtd.mk
> > index 3bac2d5..807f559 100644
> > --- a/package/mtd/mtd.mk
> > +++ b/package/mtd/mtd.mk
> > @@ -45,7 +45,10 @@ MTD_CONF_OPTS += --without-xattr
> >  endif
> >  
> >  HOST_MTD_DEPENDENCIES = host-zlib host-lzo host-util-linux
> > -HOST_MTD_CONF_OPTS = --disable-tests
> > +HOST_MTD_CONF_OPTS = \
> > +	--with-jffs \
> > +	--with-ubifs \  
> 
>  If you do this, it would also seem natural to add
> 
> --without-xattr --with-lzo

Indeed for --without-xattr. However, we don't pass
--with-lzo/--without-lzo for the target variant. Perhaps we should as
well.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  reply	other threads:[~2017-07-07  8:02 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-06 20:58 [Buildroot] [PATCH 1/3] mtd: fix build issues on older hosts Thomas Petazzoni
2017-07-06 20:58 ` [Buildroot] [PATCH 2/3] mtd: host variant needs host-util-linux, host-e2fsprogs Thomas Petazzoni
2017-07-06 22:52   ` Arnout Vandecappelle
2017-07-07  3:23   ` Baruch Siach
2017-07-06 20:58 ` [Buildroot] [PATCH 3/3] mtd: be explicit about config options for the host Thomas Petazzoni
2017-07-06 22:57   ` Arnout Vandecappelle
2017-07-07  8:02     ` Thomas Petazzoni [this message]
2017-07-06 22:52 ` [Buildroot] [PATCH 1/3] mtd: fix build issues on older hosts Arnout Vandecappelle
2017-07-07  8:02 ` Thomas Petazzoni
2017-07-07  8:21   ` Arnout Vandecappelle
2017-07-07  9:57     ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170707100218.09e408c0@windsurf.lan \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.