All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Jin Yao <yao.jin@linux.intel.com>
Cc: jolsa@kernel.org, peterz@infradead.org, mingo@redhat.com,
	alexander.shishkin@linux.intel.com, Linux-kernel@vger.kernel.org,
	ak@linux.intel.com, kan.liang@intel.com, yao.jin@intel.com
Subject: Re: [PATCH] perf report: Fix broken arrow at row 0 in annotate view
Date: Fri, 7 Jul 2017 11:21:41 -0300	[thread overview]
Message-ID: <20170707142141.GP27350@kernel.org> (raw)
In-Reply-To: <1496901704-30275-1-git-send-email-yao.jin@linux.intel.com>

Em Thu, Jun 08, 2017 at 02:01:44PM +0800, Jin Yao escreveu:
> When the jump instruction is displayed at the row 0 in annotate view,
> the arrow is broken. An example:
> 
>  16.86 │   ┌──je     82
>   0.01 │      movsd  (%rsp),%xmm0
>        │      movsd  0x8(%rsp),%xmm4
>        │      movsd  0x8(%rsp),%xmm1
>        │      movsd  (%rsp),%xmm3
>        │      divsd  %xmm4,%xmm0
>        │      divsd  %xmm3,%xmm1
>        │      movsd  (%rsp),%xmm2
>        │      addsd  %xmm1,%xmm0
>        │      addsd  %xmm2,%xmm0
>        │      movsd  %xmm0,(%rsp)
>        │82:   sub    $0x1,%ebx
>  83.03 │    ↑ jne    38
>        │      add    $0x10,%rsp
>        │      xor    %eax,%eax
>        │      pop    %rbx
>        │    ← retq
> 
> The patch increments the row number before checking with 0.

Thanks, tested and applied!

- Arnaldo

  parent reply	other threads:[~2017-07-07 14:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-08  6:01 [PATCH] perf report: Fix broken arrow at row 0 in annotate view Jin Yao
2017-07-07  5:11 ` Jin, Yao
2017-07-07 12:20   ` Arnaldo Carvalho de Melo
2017-07-07 14:21 ` Arnaldo Carvalho de Melo [this message]
2017-07-11  8:50 ` [tip:perf/urgent] perf annotate: Fix broken arrow at row 0 connecting jmp instruction to its target tip-bot for Jin Yao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170707142141.GP27350@kernel.org \
    --to=acme@kernel.org \
    --cc=Linux-kernel@vger.kernel.org \
    --cc=ak@linux.intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=jolsa@kernel.org \
    --cc=kan.liang@intel.com \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=yao.jin@intel.com \
    --cc=yao.jin@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.