All of lore.kernel.org
 help / color / mirror / Atom feed
From: Doug Berger <opendmb@gmail.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Doug Berger <opendmb@gmail.com>,
	Marc Zyngier <marc.zyngier@arm.com>,
	Bartosz Golaszewski <brgl@bgdev.pl>,
	Sebastian Frias <sf84@laposte.net>,
	Boris Brezillon <boris.brezillon@free-electrons.com>,
	linux-kernel@vger.kernel.org (open list)
Subject: [PATCH 3/6] genirq: generic chip: remove irq_gc_mask_disable_reg_and_ack()
Date: Fri,  7 Jul 2017 12:20:13 -0700	[thread overview]
Message-ID: <20170707192016.13001-4-opendmb@gmail.com> (raw)
In-Reply-To: <20170707192016.13001-1-opendmb@gmail.com>

Any usage of the irq_gc_mask_disable_reg_and_ack() function should be
replaced with either the irq_gc_mask_disable_and_ack_set() or the
irq_gc_mask_set_and_ack_set() function depending on which corrects
the bugs in irq_gc_mask_disable_reg_and_ack() for a given usage.

The incorrect and ambiguously named function is removed here to
prevent accidental misuse.

Signed-off-by: Doug Berger <opendmb@gmail.com>
---
 include/linux/irq.h       |  1 -
 kernel/irq/generic-chip.c | 16 ----------------
 2 files changed, 17 deletions(-)

diff --git a/include/linux/irq.h b/include/linux/irq.h
index 23b9617bb682..d2a9150aace7 100644
--- a/include/linux/irq.h
+++ b/include/linux/irq.h
@@ -1002,7 +1002,6 @@ void irq_gc_mask_clr_bit(struct irq_data *d);
 void irq_gc_unmask_enable_reg(struct irq_data *d);
 void irq_gc_ack_set_bit(struct irq_data *d);
 void irq_gc_ack_clr_bit(struct irq_data *d);
-void irq_gc_mask_disable_reg_and_ack(struct irq_data *d);
 void irq_gc_mask_disable_and_ack_set(struct irq_data *d);
 void irq_gc_mask_disable_and_ack_clr(struct irq_data *d);
 void irq_gc_mask_set_and_ack_set(struct irq_data *d);
diff --git a/kernel/irq/generic-chip.c b/kernel/irq/generic-chip.c
index 168887a81a29..5853d9b74924 100644
--- a/kernel/irq/generic-chip.c
+++ b/kernel/irq/generic-chip.c
@@ -135,22 +135,6 @@ void irq_gc_ack_clr_bit(struct irq_data *d)
 }
 
 /**
- * irq_gc_mask_disable_reg_and_ack - Mask and ack pending interrupt
- * @d: irq_data
- */
-void irq_gc_mask_disable_reg_and_ack(struct irq_data *d)
-{
-	struct irq_chip_generic *gc = irq_data_get_irq_chip_data(d);
-	struct irq_chip_type *ct = irq_data_get_chip_type(d);
-	u32 mask = d->mask;
-
-	irq_gc_lock(gc);
-	irq_reg_writel(gc, mask, ct->regs.mask);
-	irq_reg_writel(gc, mask, ct->regs.ack);
-	irq_gc_unlock(gc);
-}
-
-/**
  * irq_gc_mask_disable_and_ack_set - Mask and ack pending interrupt
  * @d: irq_data
  *
-- 
2.13.0

  parent reply	other threads:[~2017-07-07 19:21 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20170707192016.13001-1-opendmb@gmail.com>
2017-07-07 19:20 ` [PATCH 1/6] genirq: generic chip: add generic irq_mask_ack functions Doug Berger
2017-07-08 12:08   ` Thomas Gleixner
2017-07-10 17:39     ` Doug Berger
2017-07-17 17:23       ` Doug Berger
2017-07-17 20:58         ` Thomas Gleixner
2017-07-12 19:24   ` Doug Berger
2017-07-12 20:49     ` Måns Rullgård
2017-07-07 19:20 ` [PATCH 2/6] irqchip/tango: Use irq_gc_mask_disable_and_ack_set Doug Berger
2017-07-07 19:20   ` Doug Berger
2017-07-12 12:34   ` Marc Gonzalez
2017-07-12 12:34     ` Marc Gonzalez
2017-07-13 10:16     ` Måns Rullgård
2017-07-13 10:16       ` Måns Rullgård
2017-07-07 19:20 ` Doug Berger [this message]
2017-07-07 19:20 ` [PATCH 4/6] irqchip: brcmstb-l2: Remove some processing from the handler Doug Berger
2017-07-07 19:20   ` Doug Berger
2017-07-07 19:20   ` Doug Berger
2017-07-10 15:53   ` Florian Fainelli
2017-07-10 15:53     ` Florian Fainelli
2017-07-07 19:20 ` [PATCH 5/6] irqchip: brcmstb-l2: Abstract register accesses Doug Berger
2017-07-07 19:20   ` Doug Berger
2017-07-07 19:20   ` Doug Berger
2017-07-10 15:54   ` Florian Fainelli
2017-07-10 15:54     ` Florian Fainelli
2017-07-07 19:20 ` [PATCH 6/6] irqchip: brcmstb-l2: Add support for the BCM7271 L2 controller Doug Berger
2017-07-07 19:20   ` Doug Berger
2017-07-07 19:20   ` Doug Berger
2017-07-10 15:53   ` Rob Herring
2017-07-10 15:53     ` Rob Herring
2017-07-10 15:54   ` Florian Fainelli
2017-07-10 15:54     ` Florian Fainelli
2017-07-10 15:54     ` Florian Fainelli
2017-07-07 19:34 ` [PATCH 0/6] Add support for BCM7271 style interrupt controller Doug Berger
2017-07-07 19:34   ` Doug Berger
2017-07-07 19:34   ` Doug Berger
2017-07-07 19:39   ` Florian Fainelli
2017-07-07 19:39     ` Florian Fainelli
2017-07-07 19:39     ` Florian Fainelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170707192016.13001-4-opendmb@gmail.com \
    --to=opendmb@gmail.com \
    --cc=boris.brezillon@free-electrons.com \
    --cc=brgl@bgdev.pl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marc.zyngier@arm.com \
    --cc=sf84@laposte.net \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.