From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750960AbdGHF0L (ORCPT ); Sat, 8 Jul 2017 01:26:11 -0400 Received: from mail-pg0-f65.google.com ([74.125.83.65]:33255 "EHLO mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750816AbdGHF0K (ORCPT ); Sat, 8 Jul 2017 01:26:10 -0400 Date: Sat, 8 Jul 2017 14:24:20 +0900 From: Sergey Senozhatsky To: Joe Perches Cc: Petr Mladek , Sergey Senozhatsky , Steven Rostedt , Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [PATCH] printk: Move printk_delay to separate file Message-ID: <20170708052420.GC488@tigerII.localdomain> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (07/07/17 11:08), Joe Perches wrote: > printk.c is a huge file with too many local functions for a > human to read and easily parse. > > Start to separate out bits into smaller files. > > Miscellanea: > > o Rename suppress_message_printing to printk_suppress_message > o Add function definitions to printk.h I don't mind, in general, but I'm a bit hesitant. we want to have automatic printk throttling (printk delay basically) and we need some of those printk-internal *_seq numbers to see how far consoles are behind the logbuf. so either we need to 'un-static' those *_seq and extern them in delay.c or simply keep printk-delay machinery in printk.c and add the new function. // p.s. I'll take a look at the patch a bit later. I'm on a sick leave now. -ss