From: Stephen Hemminger <stephen@networkplumber.org>
To: Andrew Rybchenko <arybchenko@solarflare.com>
Cc: <dev@dpdk.org>,
Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>,
Remy Horton <remy.horton@intel.com>,
Jianfeng Tan <jianfeng.tan@intel.com>,
Declan Doherty <declan.doherty@intel.com>,
Ferruh Yigit <ferruh.yigit@intel.com>,
Yuanhan Liu <yuanhan.liu@linux.intel.com>,
Maxime Coquelin <maxime.coquelin@redhat.com>,
Konstantin Ananyev <konstantin.ananyev@intel.com>,
Bruce Richardson <bruce.richardson@intel.com>,
Reshma Pattan <reshma.pattan@intel.com>,
Cristian Dumitrescu <cristian.dumitrescu@intel.com>,
Byron Marohn <byron.marohn@intel.com>,
Pablo de Lara Guarch <pablo.de.lara.guarch@intel.com>,
Pawel Wodkowski <pawelx.wodkowski@intel.com>,
Tomasz Kantecki <tomasz.kantecki@intel.com>,
John McNamara <john.mcnamara@intel.com>,
Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>,
Roman Zhukov <Roman.Zhukov@oktetlabs.ru>
Subject: Re: [PATCH 2/2] examples: adjust Rx and Tx descriptors to device limits
Date: Sat, 8 Jul 2017 10:05:37 -0700 [thread overview]
Message-ID: <20170708100537.7a52d067@xeon-e3> (raw)
In-Reply-To: <1495727874-10892-2-git-send-email-arybchenko@solarflare.com>
On Thu, 25 May 2017 16:57:54 +0100
Andrew Rybchenko <arybchenko@solarflare.com> wrote:
> + retval = rte_eth_dev_adjust_nb_rx_tx_desc(portid, &nb_rxd, &nb_txd);
> + if (retval != 0)
> + rte_exit(EXIT_FAILURE, "port %u: rte_eth_dev_adjust_nb_rx_tx_desc "
> + "failed (res=%d)\n", portid, retval);
> +
rte_exit is equivalent to panic in kernel.
No API call should call rte_exit. Instead the error must be propogated
back to caller and/or leave the slave in a dead state.
next prev parent reply other threads:[~2017-07-08 17:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-02 13:05 [RFC PATCH 0/2] Helper function to ajdust Rx/Tx descriptor numbers Andrew Rybchenko
2017-03-02 13:05 ` [RFC PATCH 1/2] ethdev: add function to adjust number of descriptors Andrew Rybchenko
2017-04-24 15:13 ` Thomas Monjalon
2017-04-25 7:39 ` Andrew Rybchenko
2017-05-25 15:57 ` [PATCH " Andrew Rybchenko
2017-05-25 15:57 ` [PATCH 2/2] examples: adjust Rx and Tx descriptors to device limits Andrew Rybchenko
2017-07-08 17:05 ` Stephen Hemminger [this message]
2017-07-09 9:40 ` Andrew Rybchenko
2017-05-25 17:40 ` [PATCH 1/2] ethdev: add function to adjust number of descriptors Stephen Hemminger
2017-06-14 10:37 ` Andrew Rybchenko
2017-07-05 23:00 ` Thomas Monjalon
2017-07-08 16:45 ` Thomas Monjalon
2017-03-02 13:05 ` [RFC PATCH 2/2] examples/l3fwd: add check of Rx and Tx descriptors number Andrew Rybchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170708100537.7a52d067@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=Roman.Zhukov@oktetlabs.ru \
--cc=arybchenko@solarflare.com \
--cc=bruce.richardson@intel.com \
--cc=byron.marohn@intel.com \
--cc=cristian.dumitrescu@intel.com \
--cc=danielx.t.mrzyglod@intel.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jianfeng.tan@intel.com \
--cc=john.mcnamara@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=pawelx.wodkowski@intel.com \
--cc=remy.horton@intel.com \
--cc=reshma.pattan@intel.com \
--cc=sergio.gonzalez.monroy@intel.com \
--cc=tomasz.kantecki@intel.com \
--cc=yuanhan.liu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.