From mboxrd@z Thu Jan  1 00:00:00 1970
From: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Subject: Re: [pull-request] next-tm 17.08 pre-rc1
Date: Mon, 10 Jul 2017 09:43:17 +0200
Message-ID: <20170710074317.GR19852@6wind.com>
References: <1499182731-86830-1-git-send-email-cristian.dumitrescu@intel.com>
 <1838852.sCttUoyffy@xps>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Cristian Dumitrescu <cristian.dumitrescu@intel.com>, dev@dpdk.org,
 jerin.jacob@caviumnetworks.com, hemant.agrawal@nxp.com,
 jasvinder.singh@intel.com, wenzhuo.lu@intel.com
To: Thomas Monjalon <thomas@monjalon.net>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wr0-f173.google.com (mail-wr0-f173.google.com
 [209.85.128.173]) by dpdk.org (Postfix) with ESMTP id 84CEA5598
 for <dev@dpdk.org>; Mon, 10 Jul 2017 09:43:26 +0200 (CEST)
Received: by mail-wr0-f173.google.com with SMTP id r103so126773104wrb.0
 for <dev@dpdk.org>; Mon, 10 Jul 2017 00:43:26 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <1838852.sCttUoyffy@xps>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Thomas,

On Sun, Jul 09, 2017 at 10:01:31PM +0200, Thomas Monjalon wrote:
> Hi,
> 
> 04/07/2017 17:38, Cristian Dumitrescu:
> >   http://dpdk.org/git/next/dpdk-next-tm 
> 
> I'm sorry to not have considered this tree as a high priority.
> I think it may be integrated in RC2 because it is a totally new area
> and should not break any existing code.
> 
> I prefer to wait because I have seen some things to fix:
> 
> 1/ There is a compilation error with clang (notified in related thread).
> 
> 2/ Some functions are exposed in the API to query the ops.
> It seems dangerous and useless:
> 	- rte_eth_dev_tm_ops_get
> 	- rte_tm_ops_get
> 
> 3/ The PMD interface file is referenced in the doxygen index:
> +  [rte_tm_driver]      (@ref rte_tm_driver.h),
> I see that rte_flow_driver.h is also referenced but it seems a mistake.

Why? It was done on purpose, I think exposing through Doxygen internal APIs
implemented by drivers must be a requirement, even if the exposed symbols
are not necessarily versioned.

-- 
Adrien Mazarguil
6WIND