From: Stephen Hemminger <stephen@networkplumber.org>
To: Phil Sutter <phil@nwl.cc>
Cc: netdev@vger.kernel.org
Subject: Re: [iproute PATCH] ip netns: Make sure netns name is sane
Date: Mon, 10 Jul 2017 08:17:02 -0700 [thread overview]
Message-ID: <20170710081702.54cf6c8b@xeon-e3> (raw)
In-Reply-To: <20170710111912.22537-1-phil@nwl.cc>
On Mon, 10 Jul 2017 13:19:12 +0200
Phil Sutter <phil@nwl.cc> wrote:
> +static bool is_basename(const char *name)
> +{
> + char *name_dup = strdup(name);
> + bool rc = true;
> +
> + if (!name_dup)
> + return false;
> +
> + if (strcmp(basename(name_dup), name))
> + rc = false;
> +
> + free(name_dup);
> + return rc;
> +}
Why not just:
static bool is_basename(const char *name)
{
return strchr(name '/') == NULL;
}
next prev parent reply other threads:[~2017-07-10 15:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-10 11:19 [iproute PATCH] ip netns: Make sure netns name is sane Phil Sutter
2017-07-10 15:17 ` Stephen Hemminger [this message]
2017-07-12 12:38 ` Phil Sutter
2017-07-12 16:38 ` Stephen Hemminger
2017-07-12 18:12 ` Phil Sutter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170710081702.54cf6c8b@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=netdev@vger.kernel.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.