From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39565) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dUYSA-0004KD-UN for qemu-devel@nongnu.org; Mon, 10 Jul 2017 09:10:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dUYSA-0000qA-2N for qemu-devel@nongnu.org; Mon, 10 Jul 2017 09:10:18 -0400 Date: Mon, 10 Jul 2017 15:10:07 +0200 From: Kevin Wolf Message-ID: <20170710131007.GE5772@noname.redhat.com> References: <1498733831-15254-1-git-send-email-pl@kamp.de> <1498733831-15254-3-git-send-email-pl@kamp.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1498733831-15254-3-git-send-email-pl@kamp.de> Subject: Re: [Qemu-devel] [PATCH V2 2/8] qapi: add compress parameters to Qcow2 Blockdev options List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Lieven Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org, lersek@redhat.com, den@openvz.org, mreitz@redhat.com, eblake@redhat.com, berrange@redhat.com Am 29.06.2017 um 12:57 hat Peter Lieven geschrieben: > Signed-off-by: Peter Lieven > --- > qapi/block-core.json | 44 +++++++++++++++++++++++++++++++++++++++++++- > 1 file changed, 43 insertions(+), 1 deletion(-) How does this make sense as a runtime option? What would happen if the image contains one compression format and I specify another one on the command line or in blockdev-add? Shouldn't it just be a create-time option and when you run qemu, it uses whatever format that image has? Kevin