diff for duplicates of <20170710234339.GA15226@redhat.com> diff --git a/a/1.txt b/N1/1.txt index 82134fa..e408958 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -15,4 +15,4 @@ On Mon, Jul 10, 2017 at 03:59:37PM -0700, Evgeny Baskakov wrote: Horrible stupid bug in the code, most likely from cut and paste. Attached patch should fix it. I don't know how long it took for you to trigger it. -Jerome +Jérôme diff --git a/a/2.txt b/N1/2.txt index 8b13789..11756fb 100644 --- a/a/2.txt +++ b/N1/2.txt @@ -1 +1,41 @@ +>From 0abb8ba8e680406d8e860b2645f7f0e98f628916 Mon Sep 17 00:00:00 2001 +From: =?UTF-8?q?J=C3=A9r=C3=B4me=20Glisse?= <jglisse@redhat.com> +Date: Mon, 10 Jul 2017 19:39:24 -0400 +Subject: [PATCH] mm/hmm: fix major device driver exhaustion (dumb cut and + paste mistake) +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit +This is likely the result of some cut and paste gone wrong. + +Signed-off-by: Jérôme Glisse <jglisse@redhat.com> +--- + mm/hmm.c | 7 ------- + 1 file changed, 7 deletions(-) + +diff --git a/mm/hmm.c b/mm/hmm.c +index 28e54e3..6d1705a 100644 +--- a/mm/hmm.c ++++ b/mm/hmm.c +@@ -1206,18 +1206,11 @@ static void hmm_device_release(struct device *device) + struct hmm_device *hmm_device_new(void *drvdata) + { + struct hmm_device *hmm_device; +- int ret; + + hmm_device = kzalloc(sizeof(*hmm_device), GFP_KERNEL); + if (!hmm_device) + return ERR_PTR(-ENOMEM); + +- ret = alloc_chrdev_region(&hmm_device->device.devt, 0, 1, "hmm_device"); +- if (ret < 0) { +- kfree(hmm_device); +- return NULL; +- } +- + spin_lock(&hmm_device_lock); + hmm_device->minor = find_first_zero_bit(hmm_device_mask, HMM_DEVICE_MAX); + if (hmm_device->minor >= HMM_DEVICE_MAX) { +-- +2.9.4 diff --git a/a/content_digest b/N1/content_digest index 237c6bd..11203d1 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -35,9 +35,50 @@ "Horrible stupid bug in the code, most likely from cut and paste. Attached\n" "patch should fix it. I don't know how long it took for you to trigger it.\n" "\n" - Jerome + "J\303\251r\303\264me" "\01:2\0" "fn\00001-mm-hmm-fix-major-device-driver-exhaustion-dumb-cut-a.patch\0" "b\0" + ">From 0abb8ba8e680406d8e860b2645f7f0e98f628916 Mon Sep 17 00:00:00 2001\n" + "From: =?UTF-8?q?J=C3=A9r=C3=B4me=20Glisse?= <jglisse@redhat.com>\n" + "Date: Mon, 10 Jul 2017 19:39:24 -0400\n" + "Subject: [PATCH] mm/hmm: fix major device driver exhaustion (dumb cut and\n" + " paste mistake)\n" + "MIME-Version: 1.0\n" + "Content-Type: text/plain; charset=UTF-8\n" + "Content-Transfer-Encoding: 8bit\n" + "\n" + "This is likely the result of some cut and paste gone wrong.\n" + "\n" + "Signed-off-by: J\303\251r\303\264me Glisse <jglisse@redhat.com>\n" + "---\n" + " mm/hmm.c | 7 -------\n" + " 1 file changed, 7 deletions(-)\n" + "\n" + "diff --git a/mm/hmm.c b/mm/hmm.c\n" + "index 28e54e3..6d1705a 100644\n" + "--- a/mm/hmm.c\n" + "+++ b/mm/hmm.c\n" + "@@ -1206,18 +1206,11 @@ static void hmm_device_release(struct device *device)\n" + " struct hmm_device *hmm_device_new(void *drvdata)\n" + " {\n" + " \tstruct hmm_device *hmm_device;\n" + "-\tint ret;\n" + " \n" + " \thmm_device = kzalloc(sizeof(*hmm_device), GFP_KERNEL);\n" + " \tif (!hmm_device)\n" + " \t\treturn ERR_PTR(-ENOMEM);\n" + " \n" + "-\tret = alloc_chrdev_region(&hmm_device->device.devt, 0, 1, \"hmm_device\");\n" + "-\tif (ret < 0) {\n" + "-\t\tkfree(hmm_device);\n" + "-\t\treturn NULL;\n" + "-\t}\n" + "-\n" + " \tspin_lock(&hmm_device_lock);\n" + " \thmm_device->minor = find_first_zero_bit(hmm_device_mask, HMM_DEVICE_MAX);\n" + " \tif (hmm_device->minor >= HMM_DEVICE_MAX) {\n" + "-- \n" + 2.9.4 -2aed982c22cf5dc7b7f6234c933becfc9078703ea4b0006c4cf5650d24bdb9fc +d16ba7e5a6def2bbcfb77c3a9d2d52afc59dbd78ebe41c9d105e8fcee2e7bc51
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.