From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] support/testing: unbreak run-tests -l
Date: Mon, 10 Jul 2017 23:53:20 +0200 [thread overview]
Message-ID: <20170710235320.333b694c@windsurf.lan> (raw)
In-Reply-To: <20170710204007.8402-1-arnout@mind.be>
Hello,
On Mon, 10 Jul 2017 22:40:06 +0200, Arnout Vandecappelle
(Essensium/Mind) wrote:
> In commit b78b50465c20c1733753a8dd47945cf80c9155f8, the initialisation
> of BRTest.builddir was moved to the __init__ function. However, it is
> set based on BRTest.outputdir and that is only set when the -o argument
> is given to run-tests. When called as "run-tests -l", there is no -o
> argument so BRTest.outputdir remains unset.
>
> To fix, keep BRTest.builddir at None when BRTest.outputdir is None.
>
> While we're at it, drop the direct access to the class member. If a
> subclass wishes to set outputdir to something else before calling
> BRTest.__init__, they are free to do so.
>
> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> ---
> support/testing/infra/basetest.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2017-07-10 21:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-10 20:40 [Buildroot] [PATCH 1/2] support/testing: unbreak run-tests -l Arnout Vandecappelle
2017-07-10 20:40 ` [Buildroot] [PATCH 2/2] support/testing: add test of BR2_CCACHE with an external toolchain Arnout Vandecappelle
2017-07-15 3:07 ` Ricardo Martincoski
2017-07-18 9:38 ` Arnout Vandecappelle
2017-07-19 2:02 ` Ricardo Martincoski
2017-07-19 11:49 ` Arnout Vandecappelle
2017-07-10 20:48 ` [Buildroot] [PATCH 1/2] support/testing: unbreak run-tests -l Yann E. MORIN
2017-07-10 21:53 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170710235320.333b694c@windsurf.lan \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.