From: Stephen Hemminger <stephen@networkplumber.org>
To: Medvedkin Vladimir <medvedkinv@gmail.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH] lib/rib: Add Routing Information Base library
Date: Tue, 11 Jul 2017 13:28:07 -0700 [thread overview]
Message-ID: <20170711132807.4cbceb72@xeon-e3> (raw)
In-Reply-To: <1499801585-10031-2-git-send-email-medvedkinv@gmail.com>
On Tue, 11 Jul 2017 19:33:05 +0000
Medvedkin Vladimir <medvedkinv@gmail.com> wrote:
> +
> +#define ROUNDUP(x, y) ((((x - 1) >> (32 - y)) + 1) << (32 - y))
There is already RTE_ALIGN_FLOOR/RTE_ALIGN_CEIL
> +#define RTE_DIR24_8_GET_TBL24_P(fib, ip) \
> + ((void *)&((uint8_t *)fib->tbl24)[(ip & \
> + RTE_DIR24_8_TBL24_MASK) >> (8 - fib->nh_sz)]) \
> +
Why is this a macro and not an inline function.
The expresion could also be split up to be simpler, and compiler
would generate same result.
next prev parent reply other threads:[~2017-07-11 20:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-11 19:33 [RFC] Add RIB library Medvedkin Vladimir
2017-07-11 19:33 ` [PATCH] lib/rib: Add Routing Information Base library Medvedkin Vladimir
2017-07-11 20:28 ` Stephen Hemminger [this message]
2017-07-11 23:17 ` Vladimir Medvedkin
2017-07-11 20:31 ` [RFC] Add RIB library Stephen Hemminger
2017-07-11 23:13 ` Vladimir Medvedkin
2017-08-14 10:51 ` Bruce Richardson
2017-08-14 22:28 ` Vladimir Medvedkin
2017-08-15 8:23 ` Bruce Richardson
2017-08-15 10:49 ` Vladimir Medvedkin
2017-08-15 11:01 ` Vladimir Medvedkin
2018-01-16 0:41 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170711132807.4cbceb72@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=medvedkinv@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.