From: Pavel Machek <pavel@ucw.cz>
To: Lynn Lei <lynnl.yet@gmail.com>
Cc: rpurdie@rpsys.net, jacek.anaszewski@gmail.com,
linux-leds@vger.kernel.org
Subject: Re: [PATCH] leds: leds-aat1290.c: enclosed arithmetic expression macro
Date: Tue, 11 Jul 2017 17:31:57 +0200 [thread overview]
Message-ID: <20170711153156.GA7269@amd> (raw)
In-Reply-To: <20170711151533.GA15670@lynnl.yet>
[-- Attachment #1: Type: text/plain, Size: 1169 bytes --]
On Tue 2017-07-11 23:21:01, Lynn Lei wrote:
> Fixed the unenclosed complex values macro issue generated by
> scripts/checkpatch.pl:
> ERROR: Macros with complex values should be enclosed in parentheses
>
> Signed-off-by: Lynn Lei <lynnl.yet@gmail.com>
That's very very very stupid, right?
Please don't do random checkpatch cleanups, be careful and test your changes.
NAK.
Pavel
> ---
> drivers/leds/leds-aat1290.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/leds/leds-aat1290.c b/drivers/leds/leds-aat1290.c
> index a21e19297745..061e2cfd8097 100644
> --- a/drivers/leds/leds-aat1290.c
> +++ b/drivers/leds/leds-aat1290.c
> @@ -35,7 +35,7 @@
> #define AAT1290_MM_CURRENT_RATIO_ADDR 20
> #define AAT1290_MM_TO_FL_1_92 1
>
> -#define AAT1290_MM_TO_FL_RATIO 1000 / 1920
> +#define AAT1290_MM_TO_FL_RATIO (1000 / 1920)
> #define AAT1290_MAX_MM_CURRENT(fl_max) (fl_max * AAT1290_MM_TO_FL_RATIO)
>
> #define AAT1290_LATCH_TIME_MIN_US 500
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2017-07-11 15:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-11 15:21 [PATCH] leds: leds-aat1290.c: enclosed arithmetic expression macro Lynn Lei
2017-07-11 15:31 ` Pavel Machek [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-07-11 15:23 Lynn Lei
2017-07-11 15:42 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170711153156.GA7269@amd \
--to=pavel@ucw.cz \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-leds@vger.kernel.org \
--cc=lynnl.yet@gmail.com \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.