From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756264AbdGKR1R (ORCPT ); Tue, 11 Jul 2017 13:27:17 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:59542 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756124AbdGKR1P (ORCPT ); Tue, 11 Jul 2017 13:27:15 -0400 Date: Tue, 11 Jul 2017 19:27:12 +0200 From: Greg KH To: Mark Rogers Cc: Frans Klaver , devel@driverdev.osuosl.org, karniksayli1995@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: ks7010: fix styling WARNINGs Message-ID: <20170711172712.GB5530@kroah.com> References: <1498798361-9965-1-git-send-email-mail@mark-rogers.org> <20170630183927.GA13036@ubuntulaptop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170630183927.GA13036@ubuntulaptop> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 30, 2017 at 11:39:27AM -0700, Mark Rogers wrote: > Thank you for your feedback. I guess when making this patch I had the > preferred coding style in mind, but didn't ask myself if making the code > conform to it would truly improve readability. > > I agree with all of your comments. Do you think the best course of > action is to create a new patch with this change alone and forget the > rest? > > - DPRINTK(1, "ks7010_sdio_remove()\n"); > + DPRINTK(1, "%s()\n", __func__); Lines like this, that are just "here I am!" comments, should all be deleted anyway, we have ftrace in the kernel, people always seem to forget about it... thanks, greg k-h