From: Eduardo Habkost <ehabkost@redhat.com>
To: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
qemu-devel@nongnu.org, lersek@redhat.com, somlo@cmu.edu,
pbonzini@redhat.com, rjones@redhat.com, imammedo@redhat.com,
peter.maydell@linaro.org
Subject: Re: [Qemu-devel] [PATCHv8 1/3] fw_cfg: switch fw_cfg_find() to locate the fw_cfg device by type rather than path
Date: Tue, 11 Jul 2017 17:28:07 -0300 [thread overview]
Message-ID: <20170711202807.GC6020@localhost.localdomain> (raw)
In-Reply-To: <d9870097-46dc-40bf-49e9-7cf3276017f2@ilande.co.uk>
On Tue, Jul 11, 2017 at 09:26:22PM +0100, Mark Cave-Ayland wrote:
> On 11/07/17 21:18, Michael S. Tsirkin wrote:
>
> > Multi-line comments also should formatted
> >
> > /*
> > * like
> > * this
> > */
> >
> > not
> >
> > /* like
> > * this */
> >
>
> Interesting, I never knew there was a preferred format for comments (I
> see both styles throughout the codebase).
>
> FWIW it's probably worth pointing out that the style for multi-line
> comments isn't given in CODING_STYLE, and checkpatch didn't complain
> either...
I just noticed that, too. I will submit a patch.
--
Eduardo
next prev parent reply other threads:[~2017-07-11 20:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-11 20:02 [Qemu-devel] [PATCHv8 0/3] fw_cfg: qdev-related tidy-ups Mark Cave-Ayland
2017-07-11 20:02 ` [Qemu-devel] [PATCHv8 1/3] fw_cfg: switch fw_cfg_find() to locate the fw_cfg device by type rather than path Mark Cave-Ayland
2017-07-11 20:10 ` Eduardo Habkost
2017-07-11 20:15 ` Mark Cave-Ayland
2017-07-11 20:18 ` Michael S. Tsirkin
2017-07-11 20:26 ` Mark Cave-Ayland
2017-07-11 20:28 ` Eduardo Habkost [this message]
2017-07-11 20:49 ` Peter Maydell
2017-07-11 20:58 ` Eduardo Habkost
2017-07-11 21:04 ` Peter Maydell
2017-07-11 21:30 ` Laszlo Ersek
2017-07-11 20:02 ` [Qemu-devel] [PATCHv8 2/3] fw_cfg: move qdev_init_nofail() from fw_cfg_init1() to callers Mark Cave-Ayland
2017-07-11 21:12 ` Eduardo Habkost
2017-07-11 20:02 ` [Qemu-devel] [PATCHv8 3/3] fw_cfg: move QOM type defines and fw_cfg types into fw_cfg.h Mark Cave-Ayland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170711202807.GC6020@localhost.localdomain \
--to=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=lersek@redhat.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rjones@redhat.com \
--cc=somlo@cmu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.