From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Tue, 11 Jul 2017 23:17:01 +0200 Subject: [Buildroot] [PATCH 1/1] package/transmission: fix gtk support In-Reply-To: <87a84asr2s.fsf@dell.be.48ers.dk> References: <20170710175137.1402-1-bernd.kuhls@t-online.de> <87a84asr2s.fsf@dell.be.48ers.dk> Message-ID: <20170711231701.3850d479@windsurf.lan> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Hello, On Tue, 11 Jul 2017 21:37:15 +0200, Peter Korsgaard wrote: > > Gtk support is controlled by ARG_WITH since > > https://github.com/transmission/transmission/commit/2ccc2bbbfe2e4a26dfeaa13b56c412ea0af4ebe4 > > > Fixes a build error if libgtk2/3 was built before transmission: > > http://autobuild.buildroot.net/results/6b6/6b6ce352a9edfe3aaba82be143092a878e7715ed/ > > > Signed-off-by: Bernd Kuhls > > So this has been broken since (atleast) the version bump in early 2016? > Wow. Maybe not: configure: error: "The gtk client cannot be built without nls support. Try adding either --enable-nls or --without-gtk" Until the recent gettext revamp we were passing --disable-nls only when BR2_ENABLE_LOCALE was disabled. However, the transmission-gtk support has: depends on BR2_PACKAGE_LIBGTK2 && BR2_ENABLE_LOCALE Therefore, we were never building transmission with --disable-nls. With the gettext revamp, we now pass --disable-nls to all packages, unless BR2_SYSTEM_ENABLE_NLS is enabled (which it isn't by default). So I am not sure the fix is complete. Indeed the error says that the gtk client cannot be built without nls support. So I guess that if you have BR2_PACKCAGE_TRANSMISSION_GTK=y, but BR2_SYSTEM_ENABLE_NLS disabled it still fails to build. Best regards, Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com