From: Fam Zheng <famz@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: pbonzini@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH RFC 4/5] Introduce iothread-group
Date: Wed, 12 Jul 2017 16:44:12 +0800 [thread overview]
Message-ID: <20170712084412.GD7449@lemon> (raw)
In-Reply-To: <20170711134829.GV17792@stefanha-x1.localdomain>
On Tue, 07/11 14:48, Stefan Hajnoczi wrote:
> > + for (i = 0; i < group->size; ++i) {
>
> group->size > INT_MAX must be rejected. The error message below is
> wrong for this property:
>
> if (value < 0) {
> error_setg(&local_err, "%s value must be in range [0, %"PRId64"]",
> info->name, INT64_MAX);
Yes, I can add a PropInfo.max field so "size" can have a different max.
Fam
next prev parent reply other threads:[~2017-07-12 8:44 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-10 7:20 [Qemu-devel] [PATCH RFC 0/5] Introduce "-object iothread-group" Fam Zheng
2017-07-10 7:20 ` [Qemu-devel] [PATCH RFC 1/5] aio: Wrap poll parameters into AioContextPollParams Fam Zheng
2017-07-11 13:34 ` Stefan Hajnoczi
2017-07-10 7:20 ` [Qemu-devel] [PATCH RFC 2/5] iothread: Don't error on windows Fam Zheng
2017-07-11 13:35 ` Stefan Hajnoczi
2017-07-10 7:20 ` [Qemu-devel] [PATCH RFC 3/5] iothread: Extract iothread_start Fam Zheng
2017-07-11 13:37 ` Stefan Hajnoczi
2017-07-10 7:20 ` [Qemu-devel] [PATCH RFC 4/5] Introduce iothread-group Fam Zheng
2017-07-11 13:48 ` Stefan Hajnoczi
2017-07-12 8:44 ` Fam Zheng [this message]
2017-07-10 7:20 ` [Qemu-devel] [PATCH RFC 5/5] virtio-blk: Add iothread-group property Fam Zheng
2017-07-10 7:46 ` [Qemu-devel] [PATCH RFC 0/5] Introduce "-object iothread-group" Fam Zheng
2017-07-11 14:15 ` Stefan Hajnoczi
2017-07-11 15:14 ` Fam Zheng
2017-07-12 10:40 ` Stefan Hajnoczi
2017-07-11 14:58 ` Stefan Hajnoczi
2017-07-12 11:06 ` Fam Zheng
2017-07-14 13:18 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170712084412.GD7449@lemon \
--to=famz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.