All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Lothar Waßmann" <LW@KARO-electronics.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] Warning due to commit 6a516ef15d79
Date: Wed, 12 Jul 2017 13:44:58 +0200	[thread overview]
Message-ID: <20170712134458.376460fd@karo-electronics.de> (raw)
In-Reply-To: <71d4ac8d-00e4-9ff9-ff00-37ec46d80856@denx.de>

Hi Stefano,

On Wed, 12 Jul 2017 10:45:21 +0200 Stefano Babic wrote:
> Hi Lothar,
> 
> your recent patch :
> 
> commit 306dd7dabd6472b8b66ab5106d5a6a516ef15d79
> Author: Lothar Waßmann <LW@KARO-electronics.de>
> Date:   Tue Jun 27 15:23:16 2017 +0200
> 
>     net: fec_mxc: fix PHY initialization bug with CONFIG_DM_ETH
> 
> 
> is cause of warnings in several i.MX boards, such as:
> 
>        arm:  +   imx6ul_geam_nand
> +  struct udevice *vqmmc_dev;
> +                  ^
> +  bus = fec_get_miibus(dev, dev_id);
> +                       ^
> +drivers/net/fec_mxc.c:988:17: note: expected 'uint32_t {aka unsigned
> int}' but argument is of type 'struct udevice *'
> + struct mii_dev *fec_get_miibus(uint32_t base_addr, int dev_id)
> +                 ^
> 
> In fact, dev is a udevice and not an int as the prototype for
> fec_get_miibus(). Could you take a look, please ? Thanks !
> 
Should I resend a corrected version, or a fixup on top of this patch?


Lothar Waßmann

  reply	other threads:[~2017-07-12 11:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-12  8:45 [U-Boot] Warning due to commit 6a516ef15d79 Stefano Babic
2017-07-12 11:44 ` Lothar Waßmann [this message]
2017-07-12 15:00   ` Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170712134458.376460fd@karo-electronics.de \
    --to=lw@karo-electronics.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.