From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752781AbdGLObd (ORCPT ); Wed, 12 Jul 2017 10:31:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38432 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750899AbdGLObc (ORCPT ); Wed, 12 Jul 2017 10:31:32 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 06693303154 Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=jolsa@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 06693303154 Date: Wed, 12 Jul 2017 16:31:23 +0200 From: Jiri Olsa To: David Carrillo-Cisneros Cc: linux-kernel@vger.kernel.org, Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Alexander Shishkin , Andi Kleen , Simon Que , Wang Nan , Jiri Olsa , He Kuang , Masami Hiramatsu , David Ahern , Namhyung Kim , Stephane Eranian , Paul Turner Subject: Re: [PATCH v5 00/16] perf tool: add meta-data header support for pipe-mode Message-ID: <20170712143123.GB5583@krava> References: <20170711235307.99626-1-davidcc@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170711235307.99626-1-davidcc@google.com> User-Agent: Mutt/1.8.3 (2017-05-23) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Wed, 12 Jul 2017 14:31:31 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 11, 2017 at 04:52:51PM -0700, David Carrillo-Cisneros wrote: > v5: - Fix buffer leaking and size changes in > perf_event__synthesize_features. > - Remove unnecessary renaming. > - Remove extra tabs in do_write_string. SNIP > > Only patches 14 to 16 have a significant effect in user observed behavior. > All other are transparent preparatory changes or bug fixes. > > David Carrillo-Cisneros (16): > perf header: encapsulate read and swap > perf header: add PROCESS_STR_FUN macro > perf header: fail on write_padded error > perf util: add const modifier to buf in "writen" function > perf header: revamp do_write > perf header: add struct feat_fd for write > perf header: use struct feat_fd for print > perf header: use struct feat_fd to process header records > perf header: don't pass struct perf_file_section to process_##_feat > perf header: use struct feat_fd in read header records > perf header: make write_pmu_mappings pipe-mode friendly hum, not sure if that's an issue on my side, but I can see only patches 0-11 (above portion), missing patches 12-16: > perf header: add a buffer to struct feat_fd > perf header: change FEAT_OP* macros > perf tool: add show_feature_header to perf_tool > perf tools: add feature header record to pipe-mode > perf header: add event desc to pipe-mode header jirka