From: Christoph Hellwig <hch@lst.de>
To: Shaohua Li <shli@kernel.org>
Cc: linux-block@vger.kernel.org, axboe@fb.com,
Shaohua Li <shli@fb.com>, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 2/2] block: delete bio_uninit
Date: Thu, 13 Jul 2017 09:45:19 +0200 [thread overview]
Message-ID: <20170713074519.GA13404@lst.de> (raw)
In-Reply-To: <094050f349fdf7eed4a20335e9a7573d7c8c9b35.1499881589.git.shli@fb.com>
> static void bio_free(struct bio *bio)
> {
> struct bio_set *bs = bio->bi_pool;
> void *p;
>
> - bio_uninit(bio);
> + bio_disassociate_task(bio);
As said in the last mail I think there is no point in having this call..
> @@ -294,7 +289,7 @@ void bio_reset(struct bio *bio)
> {
> unsigned long flags = bio->bi_flags & (~0UL << BIO_RESET_BITS);
>
> - bio_uninit(bio);
> + bio_disassociate_task(bio);
.. and this one. And I suspect it would make sense to have all these
changes in a single patch.
next prev parent reply other threads:[~2017-07-13 7:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-12 18:00 [PATCH 0/2] block: two cleanup patches Shaohua Li
2017-07-12 18:00 ` [PATCH 1/2] block: delete bio_uninit in blockdev Shaohua Li
2017-07-12 18:00 ` [PATCH 2/2] block: delete bio_uninit Shaohua Li
2017-07-13 7:45 ` Christoph Hellwig [this message]
2017-07-13 16:50 ` Shaohua Li
2017-07-13 17:23 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170713074519.GA13404@lst.de \
--to=hch@lst.de \
--cc=axboe@fb.com \
--cc=linux-block@vger.kernel.org \
--cc=shli@fb.com \
--cc=shli@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.