Re: [Qemu-devel] [PATCH 08/11] s390x/flic: introduce modify_ais_mode callback

[Cornelia Huck <cohuck@redhat.com>]

On Thu, 13 Jul 2017 09:12:50 +0200
Christian Borntraeger <borntraeger@de.ibm.com> wrote:

> On 07/12/2017 05:07 PM, Cornelia Huck wrote:
> >> +
> >> +    switch (mode) {
> >> +    case SIC_IRQ_MODE_ALL:
> >> +        flic->simm &= ~AIS_MODE_MASK(isc);
> >> +        flic->nimm &= ~AIS_MODE_MASK(isc);
> >> +        break;
> >> +    case SIC_IRQ_MODE_SINGLE:
> >> +        flic->simm |= AIS_MODE_MASK(isc);
> >> +        flic->nimm &= ~AIS_MODE_MASK(isc);  
> > 
> > Can we have some documentation about the meaning of simm/nimm in qemu?
> > The one from the patch description of the respective kernel patch would
> > be fine.  
> 
> Do you want to have that description as part of the patch description or
> somewhere in the docs folder or somewhere in the code?

A comment near the definition of simm/nimm would be nice. Or in the
commit message, as for the kernel.