From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Subject: Re: [[PATCH]] Revert "leds: handle suspend/resume in heartbeat trigger" Date: Thu, 13 Jul 2017 14:03:34 +0200 Message-ID: <20170713120333.GI1363@amd> References: <1497321560-46817-1-git-send-email-bo.zhang@nxp.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="cf0hFtnykp6aONGL" Return-path: Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:50273 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751165AbdGMMDg (ORCPT ); Thu, 13 Jul 2017 08:03:36 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-leds-owner@vger.kernel.org List-Id: linux-leds@vger.kernel.org To: Linus Walleij Cc: Zhang Bo , "linux-arm-kernel@lists.infradead.org" , Richard Purdie , Jacek Anaszewski , Ulf Hansson , Grygorii Strashko , "linux-leds@vger.kernel.org" --cf0hFtnykp6aONGL Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue 2017-06-13 11:35:22, Linus Walleij wrote: > On Tue, Jun 13, 2017 at 4:39 AM, Zhang Bo wrote: >=20 > > This reverts commit 5ab92a7cb82c66bf30685583a38a18538e3807db. > > > > System cannot enter suspend mode because of heartbeat led trigger. > > In autosleep_wq, try_to_suspend function will try to enter suspend > > mode in specific period. it will get wakeup_count then call pm_notifier > > chain callback function and freeze processes. > > Heartbeat_pm_notifier is called and it call led_trigger_unregister to > > change the trigger of led device to none. It will send uevent message > > and the wakeup source count changed. As wakeup_count changed, suspend > > will abort. > > > > Signed-off-by: Zhang Bo >=20 > OK I was stupid, lesson learned. > Reviewed-by: Linus Walleij You may still want to submit patch to turn the LED off over suspend for your platform... --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --cf0hFtnykp6aONGL Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAllnYZUACgkQMOfwapXb+vI3XwCdHSHbeahObtIInB5CNE76bMGX 0TgAoLm9PvOlroMhkMZP8HPo3MwOz8oH =+CCV -----END PGP SIGNATURE----- --cf0hFtnykp6aONGL-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: pavel@ucw.cz (Pavel Machek) Date: Thu, 13 Jul 2017 14:03:34 +0200 Subject: [[PATCH]] Revert "leds: handle suspend/resume in heartbeat trigger" In-Reply-To: References: <1497321560-46817-1-git-send-email-bo.zhang@nxp.com> Message-ID: <20170713120333.GI1363@amd> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue 2017-06-13 11:35:22, Linus Walleij wrote: > On Tue, Jun 13, 2017 at 4:39 AM, Zhang Bo wrote: > > > This reverts commit 5ab92a7cb82c66bf30685583a38a18538e3807db. > > > > System cannot enter suspend mode because of heartbeat led trigger. > > In autosleep_wq, try_to_suspend function will try to enter suspend > > mode in specific period. it will get wakeup_count then call pm_notifier > > chain callback function and freeze processes. > > Heartbeat_pm_notifier is called and it call led_trigger_unregister to > > change the trigger of led device to none. It will send uevent message > > and the wakeup source count changed. As wakeup_count changed, suspend > > will abort. > > > > Signed-off-by: Zhang Bo > > OK I was stupid, lesson learned. > Reviewed-by: Linus Walleij You may still want to submit patch to turn the LED off over suspend for your platform... -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 181 bytes Desc: Digital signature URL: