From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Fabio Estevam <festevam@gmail.com>
Cc: stable <stable@vger.kernel.org>,
Peter Senna Tschudin <peter.senna@collabora.com>,
Sascha Hauer <s.hauer@pengutronix.de>
Subject: Re: imx-serial: RX DMA startup latency
Date: Thu, 13 Jul 2017 16:04:47 +0200 [thread overview]
Message-ID: <20170713140447.GA21549@kroah.com> (raw)
In-Reply-To: <CAOMZO5BZVEMEOdwe7_Z6DcMWOwj5BHEhb7E4anPsVi2KqF6y8Q@mail.gmail.com>
On Thu, Jul 13, 2017 at 11:00:00AM -0300, Fabio Estevam wrote:
> Hi Greg,
>
> On Thu, Jul 13, 2017 at 9:24 AM, Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> > On Wed, Jul 12, 2017 at 07:05:06PM -0300, Fabio Estevam wrote:
> >> From: Peter Senna Tschudin <peter.senna@collabora.com>
> >>
> >> commit 4dec2f119e86f9c91e60cdd8f0cc057452e331a9 upstream.
> >>
> >> 18a4208 introduced a change to reduce the RX DMA latency on the first reception
> >> when the serial port was opened for reading. However it was claiming a hardirq
> >> unsafe lock after a hardirq safe lock which is not allowed and causes lockdep
> >> to complain verbosely.
> >>
> >> This patch changes the code to always start RX DMA earlier, instead of
> >> relying on the flags used to open the serial port removing the code that
> >> was looking for the serial file flags.
> >>
> >> Cc: <stable@vger.kernel.org> #4.12.x
> >> Signed-off-by: Peter Senna Tschudin <peter.senna@collabora.com>
> >> Tested-by: Sascha Hauer <s.hauer@pengutronix.de>
> >> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> >> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> >> ---
> >> drivers/tty/serial/imx.c | 26 +++++---------------------
> >> 1 file changed, 5 insertions(+), 21 deletions(-)
> >
> > What are you asking for here, for this to be added to the 4.12-stable
> > tree?
>
> Yes, correct.
>
> I thought that adding "Cc: <stable@vger.kernel.org> #4.12.x" would
> make it clear.
That makes it look like any other patch being submitted upstream.
> What should I have made differently?
Below the --- line, say "Can you apply this patch to...", or even
simpler yet, just a short email saying, "Can you apply commit XXXXXX to
the 4.12-stable tree?"
anyway, will go queue this up now, thanks.
greg k-h
next prev parent reply other threads:[~2017-07-13 14:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-12 22:05 imx-serial: RX DMA startup latency Fabio Estevam
2017-07-13 12:24 ` Greg Kroah-Hartman
2017-07-13 14:00 ` Fabio Estevam
2017-07-13 14:04 ` Greg Kroah-Hartman [this message]
2017-07-13 14:28 ` Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170713140447.GA21549@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=festevam@gmail.com \
--cc=peter.senna@collabora.com \
--cc=s.hauer@pengutronix.de \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.