From: Greg KH <gregkh@linuxfoundation.org>
To: smklearn <smklearn@gmail.com>
Cc: mchehab@kernel.org, alan@linux.intel.com,
linux-media@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging drivers fixed coding style error
Date: Thu, 13 Jul 2017 16:25:22 +0200 [thread overview]
Message-ID: <20170713142522.GB25779@kroah.com> (raw)
In-Reply-To: <1499955476-10445-1-git-send-email-smklearn@gmail.com>
On Thu, Jul 13, 2017 at 07:17:56AM -0700, smklearn wrote:
> Fixed coding style error flagged checkpatch.pl:
> - ERROR: space prohibited after that open parenthesis '('
> - WARNING: Block comments use * on subsequent lines
>
> Signed-off-by: Shy More <smklearn@gmail.com>
>
> Output after fixing coding style issues:
>
> $KERN/scripts/checkpatch.pl -f
> ./media/atomisp/pci/atomisp2/css2400/runtime/isys/src/ibuf_ctrl_rmgr.c
>
> total: 0 errors, 0 warnings, 141 lines checked
Please don't put anything below the Signed-off-by: line, you will note
that all other commits are written that way.
Also, your subject: needs a lot of work, again, look at other commits
for the driver you are modifying to get it right.
good luck!
greg k-h
prev parent reply other threads:[~2017-07-13 14:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-13 14:17 [PATCH] staging drivers fixed coding style error smklearn
2017-07-13 14:25 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170713142522.GB25779@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alan@linux.intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=smklearn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.