From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37480) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dVff6-0004R1-MO for qemu-devel@nongnu.org; Thu, 13 Jul 2017 11:04:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dVff4-0000UD-27 for qemu-devel@nongnu.org; Thu, 13 Jul 2017 11:04:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58804) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dVff3-0000Sl-So for qemu-devel@nongnu.org; Thu, 13 Jul 2017 11:04:14 -0400 Date: Thu, 13 Jul 2017 17:03:58 +0200 From: Cornelia Huck Message-ID: <20170713170358.056a8fcd@gondolin> In-Reply-To: <20170713110237.6712-8-lprosek@redhat.com> References: <20170713110237.6712-1-lprosek@redhat.com> <20170713110237.6712-8-lprosek@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 7/8] virtio-scsi: use virtqueue_error for errors with queue context List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ladi Prosek Cc: qemu-devel@nongnu.org, casasfernando@hotmail.com, mst@redhat.com, jasowang@redhat.com, armbru@redhat.com, groug@kaod.org, arei.gonglei@huawei.com, aneesh.kumar@linux.vnet.ibm.com, stefanha@redhat.com On Thu, 13 Jul 2017 13:02:36 +0200 Ladi Prosek wrote: > virtqueue_error includes queue index in the error output and is preferred > for errors that pertain to a virtqueue rather than to the device as a whole. > > Signed-off-by: Ladi Prosek > --- > hw/scsi/virtio-scsi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/scsi/virtio-scsi.c b/hw/scsi/virtio-scsi.c > index d076fe7..a633d51 100644 > --- a/hw/scsi/virtio-scsi.c > +++ b/hw/scsi/virtio-scsi.c > @@ -84,7 +84,7 @@ static void virtio_scsi_complete_req(VirtIOSCSIReq *req) > > static void virtio_scsi_bad_req(VirtIOSCSIReq *req) > { > - virtio_error(VIRTIO_DEVICE(req->dev), "wrong size for virtio-scsi headers"); > + virtqueue_error(req->vq, "wrong size for virtio-scsi headers"); > virtqueue_detach_element(req->vq, &req->elem, 0); > virtio_scsi_free_req(req); > } Reviewed-by: Cornelia Huck