From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH RESEND] drm/i915: Fix pipe/transcoder enum mismatches Date: Thu, 13 Jul 2017 20:42:32 +0300 Message-ID: <20170713174232.GK12629@intel.com> References: <20170420215605.176722-1-mka@chromium.org> <20170505172636.GA128305@google.com> <20170505174043.GK12629@intel.com> <20170713101351.GS12629@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: =?iso-8859-1?Q?St=E9phane?= Marchesin Cc: David Airlie , intel-gfx , Linux Kernel Mailing List , "dri-devel@lists.freedesktop.org" , Michael Davidson , Grant Grundler , Matthias Kaehlcke , Greg Hackmann , Daniel Vetter List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBKdWwgMTMsIDIwMTcgYXQgMDk6MjM6MTFBTSAtMDcwMCwgU3TDqXBoYW5lIE1hcmNo ZXNpbiB3cm90ZToKPiBPbiBUaHUsIEp1bCAxMywgMjAxNyBhdCAzOjEzIEFNLCBWaWxsZSBTeXJq w6Rsw6QKPiA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+IHdyb3RlOgo+ID4gT24gV2Vk LCBKdWwgMTIsIDIwMTcgYXQgMDc6Mjg6MTRQTSAtMDcwMCwgU3TDqXBoYW5lIE1hcmNoZXNpbiB3 cm90ZToKPiA+PiBPbiBGcmksIE1heSA1LCAyMDE3IGF0IDEwOjQwIEFNLCBWaWxsZSBTeXJqw6Rs w6QKPiA+PiA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+IHdyb3RlOgo+ID4+ID4KPiA+ PiA+IE9uIEZyaSwgTWF5IDA1LCAyMDE3IGF0IDEwOjI2OjM2QU0gLTA3MDAsIE1hdHRoaWFzIEth ZWhsY2tlIHdyb3RlOgo+ID4+ID4gPiBFbCBUaHUsIEFwciAyMCwgMjAxNyBhdCAwMjo1NjowNVBN IC0wNzAwIE1hdHRoaWFzIEthZWhsY2tlIGhhIGRpdDoKPiA+PiA+ID4KPiA+PiA+ID4gPiBJbiBz ZXZlcmFsIGluc3RhbmNlcyB0aGUgZHJpdmVyIHBhc3NlcyBhbiAnZW51bSBwaXBlJyB2YWx1ZSB0 byBhCj4gPj4gPiA+ID4gZnVuY3Rpb24gZXhwZWN0aW5nIGFuICdlbnVtIHRyYW5zY29kZXInIGFu ZCB2aWNldmVyc2EuIFNpbmNlIFBJUEVfeCBhbmQKPiA+PiA+ID4gPiBUUkFOU0NPREVSX3ggaGF2 ZSB0aGUgc2FtZSB2YWx1ZXMgdGhpcyBkb2Vzbid0IGNhdXNlIGZ1bmN0aW9uYWwKPiA+PiA+ID4g PiBwcm9ibGVtcy4gU3RpbGwgaXQgaXMgaW5jb3JyZWN0IGFuZCBjYXVzZXMgY2xhbmcgdG8gZ2Vu ZXJhdGUgd2FybmluZ3MKPiA+PiA+ID4gPiBsaWtlIHRoaXM6Cj4gPj4gPiA+ID4KPiA+PiA+ID4g PiBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmM6MTg0NDozNDogd2FybmluZzog aW1wbGljaXQKPiA+PiA+ID4gPiAgIGNvbnZlcnNpb24gZnJvbSBlbnVtZXJhdGlvbiB0eXBlICdl bnVtIHRyYW5zY29kZXInIHRvIGRpZmZlcmVudAo+ID4+ID4gPiA+ICAgZW51bWVyYXRpb24gdHlw ZSAnZW51bSBwaXBlJyBbLVdlbnVtLWNvbnZlcnNpb25dCj4gPj4gPiA+ID4gICAgIGFzc2VydF9m ZGlfcnhfZW5hYmxlZChkZXZfcHJpdiwgVFJBTlNDT0RFUl9BKTsKPiA+PiA+ID4gPgo+ID4+ID4g PiA+IENoYW5nZSB0aGUgY29kZSB0byBwYXNzIHZhbHVlcyBvZiB0aGUgdHlwZSBleHBlY3RlZCBi eSB0aGUgY2FsbGVlLgo+ID4+ID4gPiA+Cj4gPj4gPiA+ID4gU2lnbmVkLW9mZi1ieTogTWF0dGhp YXMgS2FlaGxja2UgPG1rYUBjaHJvbWl1bS5vcmc+Cj4gPj4gPiA+ID4gLS0tCj4gPj4gPiA+ID4g IGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyB8IDQgKystLQo+ID4+ID4gPiA+ ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jICAgICAgfCA2ICsrKystLQo+ID4+ID4g PiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9oZG1pLmMgICAgfCA2ICsrKystLQo+ID4+ ID4gPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9zZHZvLmMgICAgfCA2ICsrKystLQo+ ID4+ID4gPiA+ICA0IGZpbGVzIGNoYW5nZWQsIDE0IGluc2VydGlvbnMoKyksIDggZGVsZXRpb25z KC0pCj4gPj4gPiA+Cj4gPj4gPiA+IFBpbmcsIGFueSBjb21tZW50cyBvbiB0aGlzIHBhdGNoPwo+ ID4+ID4KPiA+PiA+IEknbSBub3QgY29udmluY2VkIHRoZSBwYXRjaCBpcyBtYWtpbmcgdGhpbmdz IGFueSBiZXR0ZXIgcmVhbGx5LiBUbwo+ID4+ID4gZml4IHRoaXMgcmVhbGx5IHByb3Blcmx5LCBJ IHRoaW5rIHdlJ2QgbmVlZCB0byBpbnRyb2R1Y2UgYSBuZXcgZW51bQo+ID4+ID4gcGNoX3RyYW5z Y29kZXIgYW5kIHRodXMgYXZvaWQgdGhlIGNvbmZ1c2lvbiBvZiB3aGljaCB0eXBlIG9mCj4gPj4g PiB0cmFuc2NvZGVyIHdlJ3JlIHRhbGtpbmcgYWJvdXQuIEN1cnJlbnRseSBtb3N0IHBsYWNlcyBl eHBlY3QgYW4KPiA+PiA+IGVudW0gcGlwZSB3aGVuIGRlYWxpbmcgd2l0aCBQQ0ggdHJhbnNjb2Rl cnMsIGFuZCBlbnVtIHRyYW5zY29kZXIKPiA+PiA+IHdoZW4gZGVhbGluZyB3aXRoIENQVSB0cmFu c2NvZGVycy4gQnV0IHRoZXJlIGFyZSBzb21lIGV4Y2VwdGlvbnMKPiA+PiA+IG9mIGNvdXJzZS4K PiA+Pgo+ID4+Cj4gPj4gSSBkb24ndCBmb2xsb3cgLS0gdGhlc2UgZnVuY3Rpb25zIHRha2UgYW4g ZW51bSB0cmFuc2NvZGVyOyB3aGF0J3MKPiA+PiB3cm9uZyBhYm91dCBwYXNzaW5nIHdoYXQgdGhl eSBleHBlY3Q/IEl0IHNlZW1zIGxpa2Ugd2hhdCB5b3UgYXJlCj4gPj4gYXNraW5nIGZvciBoYXMg bm90aGluZyB0byBkbyB3aXRoIHRoZSB3YXJuaW5nIGhlcmUuLi4KPiA+Cj4gPiBUaGVyZSdzIGEg d2FybmluZz8gSSBkb24ndCBnZXQgYW55Lgo+IAo+IFl1cCwgY2xhbmcgZ2VuZXJhdGVzIGEgd2Fy bmluZy4KPiAKPiA+Cj4gPiBBbnl3YXlzLCBJIGp1c3QgZG9uJ3Qgc2VlIG11Y2ggcG9pbnQgaW4g YmxpbmRseSBjaGFuZ2luZyB0aGUgdHlwZXMKPiA+IGJlY2F1c2UgaXQgZG9lc24ndCBhY3R1YWxs eSBzb2x2ZSB0aGUgdW5kZXJseWluZyBjb25mdXNpb24gZm9yIGh1bWFuCj4gPiByZWFkZXJzLiBJ dCBtaWdodCBldmVuIG1ha2UgaXQgd29yc2UsIG5vdCBzdXJlLgo+IAo+IFRoZSBmdW5jdGlvbiBl eHBlY3RzIHR5cGUgQSwgeW91IHBhc3MgdHlwZSBCLCBob3cgY2FuIHRoYXQgZXZlciBiZSB0aGUK PiByaWdodCB0aGluZyB0byBkbz8KCkJlY2F1c2UgbWF5YmUgdGhlIGZ1bmN0aW9uIHNob3VsZCBi ZSB0YWtpbmcgaW4gdHlwZSBCIGluc3RlYWQuCgotLSAKVmlsbGUgU3lyasOkbMOkCkludGVsIE9U QwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1n ZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9s aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752450AbdGMRmk (ORCPT ); Thu, 13 Jul 2017 13:42:40 -0400 Received: from mga04.intel.com ([192.55.52.120]:60227 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751017AbdGMRmj (ORCPT ); Thu, 13 Jul 2017 13:42:39 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,354,1496127600"; d="scan'208";a="111004587" Date: Thu, 13 Jul 2017 20:42:32 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: =?iso-8859-1?Q?St=E9phane?= Marchesin Cc: Matthias Kaehlcke , "dri-devel@lists.freedesktop.org" , David Airlie , intel-gfx , Linux Kernel Mailing List , Michael Davidson , Grant Grundler , Greg Hackmann , Daniel Vetter Subject: Re: [Intel-gfx] [PATCH RESEND] drm/i915: Fix pipe/transcoder enum mismatches Message-ID: <20170713174232.GK12629@intel.com> References: <20170420215605.176722-1-mka@chromium.org> <20170505172636.GA128305@google.com> <20170505174043.GK12629@intel.com> <20170713101351.GS12629@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 13, 2017 at 09:23:11AM -0700, Stéphane Marchesin wrote: > On Thu, Jul 13, 2017 at 3:13 AM, Ville Syrjälä > wrote: > > On Wed, Jul 12, 2017 at 07:28:14PM -0700, Stéphane Marchesin wrote: > >> On Fri, May 5, 2017 at 10:40 AM, Ville Syrjälä > >> wrote: > >> > > >> > On Fri, May 05, 2017 at 10:26:36AM -0700, Matthias Kaehlcke wrote: > >> > > El Thu, Apr 20, 2017 at 02:56:05PM -0700 Matthias Kaehlcke ha dit: > >> > > > >> > > > In several instances the driver passes an 'enum pipe' value to a > >> > > > function expecting an 'enum transcoder' and viceversa. Since PIPE_x and > >> > > > TRANSCODER_x have the same values this doesn't cause functional > >> > > > problems. Still it is incorrect and causes clang to generate warnings > >> > > > like this: > >> > > > > >> > > > drivers/gpu/drm/i915/intel_display.c:1844:34: warning: implicit > >> > > > conversion from enumeration type 'enum transcoder' to different > >> > > > enumeration type 'enum pipe' [-Wenum-conversion] > >> > > > assert_fdi_rx_enabled(dev_priv, TRANSCODER_A); > >> > > > > >> > > > Change the code to pass values of the type expected by the callee. > >> > > > > >> > > > Signed-off-by: Matthias Kaehlcke > >> > > > --- > >> > > > drivers/gpu/drm/i915/intel_display.c | 4 ++-- > >> > > > drivers/gpu/drm/i915/intel_dp.c | 6 ++++-- > >> > > > drivers/gpu/drm/i915/intel_hdmi.c | 6 ++++-- > >> > > > drivers/gpu/drm/i915/intel_sdvo.c | 6 ++++-- > >> > > > 4 files changed, 14 insertions(+), 8 deletions(-) > >> > > > >> > > Ping, any comments on this patch? > >> > > >> > I'm not convinced the patch is making things any better really. To > >> > fix this really properly, I think we'd need to introduce a new enum > >> > pch_transcoder and thus avoid the confusion of which type of > >> > transcoder we're talking about. Currently most places expect an > >> > enum pipe when dealing with PCH transcoders, and enum transcoder > >> > when dealing with CPU transcoders. But there are some exceptions > >> > of course. > >> > >> > >> I don't follow -- these functions take an enum transcoder; what's > >> wrong about passing what they expect? It seems like what you are > >> asking for has nothing to do with the warning here... > > > > There's a warning? I don't get any. > > Yup, clang generates a warning. > > > > > Anyways, I just don't see much point in blindly changing the types > > because it doesn't actually solve the underlying confusion for human > > readers. It might even make it worse, not sure. > > The function expects type A, you pass type B, how can that ever be the > right thing to do? Because maybe the function should be taking in type B instead. -- Ville Syrjälä Intel OTC