From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/Makefile.in: export O= to post-build/image scripts for out-of-tree builds
Date: Fri, 14 Jul 2017 23:53:13 +0200 [thread overview]
Message-ID: <20170714215313.GC3373@scaer> (raw)
In-Reply-To: <20170714130417.18857-1-peter@korsgaard.com>
Peter, All,
On 2017-07-14 15:04 +0200, Peter Korsgaard spake thusly:
> Sometimes it can be interesting to call back into buildroot from a
> post-build/image script (E.G. make printvars or similar). For this to work
> correctly with out-of-tree builds we need to pass O= to make, but this is
> currently not available in the environment of post-build/image scripts.
>
> In concept, O could be derrived from BUILD_DIR (E.G. by stripping /build),
> but directly exporting O is cleaner.
>
> O= cannot be exported globally as it interferes with various build systems,
> so instead add it to EXTRA_ENV.
>
> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> ---
> package/Makefile.in | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/package/Makefile.in b/package/Makefile.in
> index b95e5e3fa8..a2b0d90f32 100644
> --- a/package/Makefile.in
> +++ b/package/Makefile.in
> @@ -309,7 +309,8 @@ HOST_CONFIGURE_OPTS = \
> EXTRA_ENV = \
> PATH=$(BR_PATH) \
> BR2_DL_DIR=$(BR2_DL_DIR) \
> - BUILD_DIR=$(BUILD_DIR)
> + BUILD_DIR=$(BUILD_DIR) \
> + O=$(CANONICAL_O)
>
> ################################################################################
> # settings we need to pass to configure
> --
> 2.11.0
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2017-07-14 21:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-14 13:04 [Buildroot] [PATCH] package/Makefile.in: export O= to post-build/image scripts for out-of-tree builds Peter Korsgaard
2017-07-14 21:53 ` Yann E. MORIN [this message]
2017-07-15 8:11 ` Thomas Petazzoni
2017-07-17 20:52 ` Arnout Vandecappelle
2017-07-17 21:32 ` Peter Korsgaard
2017-07-17 21:34 ` Arnout Vandecappelle
2017-07-18 12:47 ` Peter Korsgaard
2017-07-18 13:18 ` Arnout Vandecappelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170714215313.GC3373@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.