From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthias Kaehlcke Subject: Re: [PATCH RESEND] drm/i915: Fix pipe/transcoder enum mismatches Date: Fri, 14 Jul 2017 16:38:40 -0700 Message-ID: <20170714233840.GK95735@google.com> References: <20170505174043.GK12629@intel.com> <20170713101351.GS12629@intel.com> <20170713174232.GK12629@intel.com> <87eftjl6xg.fsf@nikula.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Grant Grundler Cc: intel-gfx , Linux Kernel Mailing List , "dri-devel@lists.freedesktop.org" , Michael Davidson , =?utf-8?B?U3TDqXBoYW5l?= Marchesin , Daniel Vetter List-Id: dri-devel@lists.freedesktop.org RWwgRnJpLCBKdWwgMTQsIDIwMTcgYXQgMDM6NDM6MzVQTSAtMDcwMCBHcmFudCBHcnVuZGxlciBo YSBkaXQ6Cgo+IE9uIEZyaSwgSnVsIDE0LCAyMDE3IGF0IDI6MzUgUE0sIERhbmllbCBWZXR0ZXIg PGRhbmllbEBmZndsbC5jaD4gd3JvdGU6Cj4gPiBPbiBGcmksIEp1bCAxNCwgMjAxNyBhdCA3OjMy IFBNLCBHcmFudCBHcnVuZGxlciA8Z3J1bmRsZXJAY2hyb21pdW0ub3JnPiB3cm90ZToKPiA+PiBP biBGcmksIEp1bCAxNCwgMjAxNyBhdCAyOjExIEFNLCBKYW5pIE5pa3VsYQo+ID4+IDxqYW5pLm5p a3VsYUBsaW51eC5pbnRlbC5jb20+IHdyb3RlOgo+ID4+PiBPbiBUaHUsIDEzIEp1bCAyMDE3LCBT dMOpcGhhbmUgTWFyY2hlc2luIDxzdGVwaGFuZS5tYXJjaGVzaW5AZ21haWwuY29tPiB3cm90ZToK PiA+Pj4+IFNvLCBpZiB5b3UgdGhpbmsgdGhpcyBpcyB3cm9uZywgY2FuIHlvdSBmaXggdGhpcyB3 YXJuaW5nIGluIGEgd2F5IHRoYXQKPiA+Pj4+IHlvdSdkIGxpa2U/Cj4gPj4+Cj4gPj4+IEFzIEkg cmVwbGllZCBwcmV2aW91c2x5IFsxXSwgd2l0aCBtb3JlIGJhY2tncm91bmQsIGZpeGluZyB0aGUg d2FybmluZ3MKPiA+Pj4gcHJvcGVybHksIGluIGEgd2F5IHRoYXQgYWN0dWFsbHkgaW1wcm92ZXMg dGhlIGNvZGUgaW5zdGVhZCBvZiBtYWtpbmcgaXQKPiA+Pj4gd29yc2UsIHdvdWxkIG1lYW4gYSBi dW5jaCBvZiBjaHVybiB0aGF0J3Mgbm90IGp1c3QgcHVyZWx5IG1lY2hhbmljYWwKPiA+Pj4gY29u dmVyc2lvbi4KPiA+Pgo+ID4+IFRoYXQncyBmYWlyLgo+ID4+Cj4gPj4+IFVubGVzcyB5b3UgY2Fu IHBvaW50IG91dCBhIGJ1ZyB3aGljaCBpcyBhY3R1YWxseSBjYXVzZWQgYnkgbWl4aW5nIHRoZQo+ ID4+PiB0eXBlcyAod2hpY2ggaXMgbW9zdGx5IGludGVudGlvbmFsLCBzZWUgdGhlIGJhY2tncm91 bmQpIEkgaGF2ZSBhIGhhcmQKPiA+Pj4gdGltZSB0ZWxsaW5nIHBlb3BsZSB0aGlzIHNob3VsZCBi ZSBhIHByaW9yaXR5Lgo+ID4+Cj4gPj4gVGhpcyBmZWVscyBsaWtlICJjYW4ndCBzZWUgdGhlIGZv cmVzdCBiZWNhdXNlIG9mIHRoZSB0cmVlcyIuCj4gPj4KPiA+PiBUaGUgb3JpZ2luYWwgcGF0Y2gg d2FzIHN1Ym1pdHRlZCBpbiBvcmRlciB0byBjb21waWxlIGNsZWFubHkgdXNpbmcKPiA+PiBjbGFu ZyBhbmQgdGhlIGFib3ZlIHN1Z2dlc3RzIHVzaW5nIGNsYW5nIGlzIG5vdCBpbXBvcnRhbnQuICBV c2luZwo+ID4+IGNsYW5nIGlzIGltcG9ydGFudCB0byBNYXR0aGlhcyBhbmQgdGhlIENocm9tZSBP UyBvcmdhbml6YXRpb24gZm9yIG1hbnkKPiA+PiBnb29kIHJlYXNvbnMgLSBpbmNsdWRpbmcgYmV0 dGVyIHdhcm5pbmdzLgo+ID4+Cj4gPj4gVGhlIG9yaWdpbmFsIHBhdGNoIG1lc3NhZ2Ugd2FzIGNs ZWFyIHRoYXQgY2xhbmcgd2FzIGdlbmVyYXRpbmcgdGhlCj4gPj4gd2FybmluZy4gVGhpcyBpc24n dCB0aGUgb25seSBwYXRjaCBta2EgaGFzIHNlbnQgdG8ga2VybmVsIGRldnMuIFdoYXQKPiA+PiBv bmUgY2FuIGluZmVyIGlzIENocm9tZSBPUyBpcyB0cnlpbmcgdG8gbW92ZSB0byBjbGFuZyAobGlr ZSBvdGhlcgo+ID4+IEdvb2dsZSBwcm9kdWN0cyBfYWxyZWFkeV8gaGF2ZS4pICBNeSBpbXByZXNz aW9uIGlzIGFsbCB0aGVzZSBwcm9kdWN0cwo+ID4+IGFyZSBhIHByaW9yaXR5IHRvIEludGVsIC0g YnV0IGl0IHdvdWxkIGJlIGdvb2QgdG8ga25vdyBvdGhlcndpc2UuCj4gPj4KPiA+Pj4gRGVmaW5p dGVseSBzb21ldGhpbmcgd2UnZAo+ID4+PiBsaWtlIHRvIGRvIGluIHRoZSBsb25nIHJ1biBhbmQg cGVkYW50aWNhbGx5IGNvcnJlY3QgKGFuZCBJIHRlbmQgdG8KPiA+Pj4gcHJlZmVyIGNvZGUgdGhh dCB3YXkpIGJ1dCB3ZSBjZXJ0YWlubHkgaGF2ZSBtb3JlIGltcG9ydGFudCB0aGluZ3MgdG8gZG8u Cj4gPj4KPiA+PiBUaGUgbG9uZyBydW4gaXMgbm93LiBFdmVyeW9uZSBhZ3JlZXMgdGhlIGNvZGUg c2hvdWxkIGNoYW5nZSBhbmQgeW91Cj4gPj4gZG9uJ3QgaGF2ZSB0byBkbyBpdC4gTWF0dGhpYXMg c3VibWl0dGVkIGFuIHVuYWNjZXB0YWJsZSBwYXRjaCBhbmQKPiA+PiBnaXZpbmcgaGltIHNvbWUg Y29uY3JldGUgZ3VpZGFuY2Ugb24gd2hhdCB3b3VsZCBiZSBhY2NlcHRhYmxlIHdvdWxkCj4gPj4g ZW5hYmxlIGhpbSB0byBpbXBsZW1lbnQvdGVzdCBpdCAob3IgYW55b25lIGVsc2UgY291bGQgZm9y IHRoYXQKPiA+PiBtYXR0ZXIpLiAgQ2FuIHlvdSBkbyB0aGF0Pwo+ID4+Cj4gPj4gSnVzdCBnaXZl IGFuIGV4YW1wbGUgb2Ygd2hhdCB0aGUgInJpZ2h0IiBBUEkgbG9va3MgbGlrZSBhbmQgc2VlIHdo ZXJlIGl0IGdvZXMuCj4gPgo+ID4gV2UndmUgcmVwbGllZCBhbmQgZGlzY3Vzc2VkIG9uIE1heSA1 dGggd2hhdCB0aGF0IHJvdWdobHkgc2hvdWxkIGJlLAo+ID4gcmlnaHQgd2hlbiBNYXR0aGlhcyBw aW5nZWQgdXMuIFRoZSBvcmlnaW5hbCBzdWJtaXNzaW9uIHVuZm9ydHVuYXRlbHkKPiA+IGZlbGwg dGhyb3VnaCB0aGUgY3JhY2tzIChpdCBoYXBwZW5zLCBub3QgbXVjaCB3ZSBjYW4gZG8gd2l0aCB0 aGlzCj4gPiBmbG9vZCkuIE1hdHRoaWFzIGRpZG4ndCBzZWVtIHRvIGhhdmUgYW55IHF1ZXN0aW9u cyBhYm91dCB0aGUgcHJvcG9zZWQKPiA+IHNvbHV0aW9ucyAod2UgbGFpZCBvdXQgYm90aCB0aGUg bWluaW1hbCBzaG9ydC10ZXJtIGZpeCB0byB1bmNvbmZ1c2UKPiA+IHRoaW5ncywgYW5kIHdoYXQg bWlnaHQgYmUgZG9uZSBvbiB0b3ApLCBJIHRoaW5rIGEgcmVhc29uYWJsZQo+ID4gYXNzdW1wdGlv biB3YXMgdGhhdCBpdCdzIGFsbCBjbGVhci4gT3RoZXJ3aXNlIGhlIHNob3VsZCBoYXZlIGFza2Vk Lgo+IAo+IEluZGVlZCEKPiAKPiBBZnRlciBicmllZmx5IGNoYXR0aW5nIHdpdGggU3RlcGhhbmUg YW5kIG1rYSwgaXQgc2VlbXMgdGhlIGRpZmZlcmVuY2UKPiBiZXR3ZWVuIHNob3J0LXRlcm0gZml4 IGFuZCAiZG9uZSBvbiB0b3AiIHdlcmUgbm90IGNsZWFyLgo+IAo+ID4gTm93LCBvdmVyIDIgbW9u dGhzIGxhdGVyIChhbmQgY29tcGxldGUgc2lsZW5jZSBmcm9tIHlvdXIgc2lkZSkgdGhlcmUncwo+ ID4gc3VkZGVubHkgbWFzcyBwYW5pYyBhbmQgbXVsdGlwbGUgZXNjYWxhdGlvbnMgb24gYWxsIGF2 YWlsYWJsZQo+ID4gY2hhbm5lbHMsIHdoaWNoIGZlZWxzIGxpa2UgYSByYXRoZXIgZGVjZW50IG92 ZXJyZWFjdGlvbiBhbmQgbm90IGEKPiA+IHRlcnJpYmxlIGNvbnN0cnVjdGl2ZSB3YXkgdG8gY29s bGFib3JhdGUgb24gdGhlIHVwc3RyZWFtIGNvZGViYXNlLgo+IAo+IEknbSBzb3JyeSAtIEknbSBu b3Qgb24gdGhlIG90aGVyIGNoYW5uZWxzIGFuZCBJIGRpZG4ndCBzZWUgYW55IG1hc3MKPiBwYW5p Yy4gSSBhZ3JlZSB0aGF0J3Mgbm90IGEgY29sbGFib3JhdGl2ZS4gVGhlIHByZXZpb3VzIGFuc3dl ciBpbiB0aGlzCj4gdGhyZWFkIGRpZG4ndCBzZWVtIHBhcnRpY3VsYXJseSBjb2xsYWJvcmF0aXZl IGVpdGhlciB0aG91Z2guCj4gCj4gVGhlIHNpbGVuY2Ugd2FzIHBhcnRseSBkdWUgdG8gbWthIHdv cmtpbmcgb24gb3RoZXIgImNsYW5nIGVuYWJsZW1lbnQiIHBhdGNoZXM6CgpZZXMsIHNvcnJ5IGZv ciB0aGUgc2lsZW5jZSA6KAoKV2l0aCBteSBsYWNrIG9mIGV4cGVydGlzZSB3aXRoIHRoaXMgZHJp dmVyIGFuZCBncmFwaGljcyBpbiBnZW5lcmFsIEkKd2Fzbid0IHN1cmUgaWYgSSdkIHRha2UgdXAg dGhlICJkb25lIG9uIHRvcCIgc29sdXRpb24gYW5kIHNoaWZ0ZWQgbXkKYXR0ZW50aW9uIHRvIG90 aGVyIGNsYW5nIHJlbGF0ZWQgaXNzdWVzLgoKPiAkIHB3Y2xpZW50IGxpc3QgLXcgbWthQGNocm9t aXVtLm9yZwo+IFBhdGNoZXMgc3VibWl0dGVkIGJ5IE1hdHRoaWFzIEthZWhsY2tlIDxta2FAY2hy b21pdW0ub3JnPjoKPiBJRCAgICAgIFN0YXRlICAgICAgICBOYW1lCj4gLS0gICAgICAtLS0tLSAg ICAgICAgLS0tLQo+IDk2NjgwOTUgU3VwZXJzZWRlZCAgIG1hYzgwMjExOiBGaXggY2xhbmcgd2Fy bmluZyBhYm91dCBjb25zdGFudAo+IG9wZXJhbmQgaW4gbG9naWNhbCBvcGVyYXRpb24KPiA5NjY4 NDc5IEFjY2VwdGVkICAgICBhdGg5azogQWRkIGNhc3QgdG8gdTggdG8gRlJFUTJGQklOIG1hY3Jv Cj4gOTY2ODY0MyBBY2NlcHRlZCAgICAgW3YyXSBtYWM4MDIxMTogRml4IGNsYW5nIHdhcm5pbmcg YWJvdXQgY29uc3RhbnQKPiBvcGVyYW5kIGluIGxvZ2ljYWwgb3BlcmF0aW9uCj4gOTY3OTc1MyBB Y2NlcHRlZCAgICAgW3YyXSBjZmc4MDIxMTogRml4IGFycmF5LWJvdW5kcyB3YXJuaW5nIGluIGZy YWdtZW50IGNvcHkKPiA5Njg0NTQ3IEFjY2VwdGVkICAgICBtYWM4MDIxMTogaWJzczogRml4IGNo YW5uZWwgdHlwZSBlbnVtIGluCj4gaWVlZTgwMjExX3N0YV9qb2luX2lic3MoKQo+IDk2ODQ2Mjkg QWNjZXB0ZWQgICAgIG5sODAyMTE6IEZpeCBlbnVtIHR5cGUgb2YgdmFyaWFibGUgaW4KPiBubDgw MjExX3B1dF9zdGFfcmF0ZSgpCj4gCj4gPiBBbnl3YXksIEkndmUgZG9uZSB0aGUgcXVpY2sgZHJh ZnQgZm9yIHRoZSBmdW5jdGlvbiBkZWNsYXJhdGlvbiBjaGFuZ2VzCj4gPiB0aGF0IHdvdWxkIGNs ZWFyIHVwIHRoZSBjb25mdXNpb24sIGp1c3QgbmVlZHMgYSBjbGFuZyBydW4gdG8gdXBkYXRlCj4g PiBhbGwgdGhlIHBhcmFtZXRlcnMgdG8gbWF0Y2gsIGFuZCBwYXNzZWQgdGhhdCBvbiB0byBTdMOp cGhhbmUgTWFyY2hlc2luLgoKVGhhbmtzLCB0aGF0IGlzIGhlbHBmdWwhCgo+IEF3ZXNvbWUgLSB0 aGFua3MhIDopCj4gCj4gPiBJIGV4cGVjdCB5b3UgdG8gZm9sbG93IHVwIHdpdGggdGhlIGNvcnJl c3BvbmRpbmcgcGF0Y2ggcmlnaHQgYXdheS4KPiAKPiBta2Egc2FpZCAiaGUgd291bGQgdGFrZSBh IGxvb2sgYXQgaXQiLiBCdXQga25vd2luZyBob3cgaGUgdW5kZXJzdGF0ZXMKPiB0aGluZ3MgaW4g YSB0eXBpY2FsICJHZXJtYW4gRW5naW5lZXIiIHdheSwgSSdtIG9wdGltaXN0aWMgaXQgd2lsbCBi ZQo+IG1vcmUgdGhhbiB0aGF0LiBUaGFua3MhCj4gCj4gY2hlZXJzLAo+IGdyYW50Cj4gCj4gPgo+ ID4gVGhhbmtzIGEgbG90Lgo+ID4KPiA+IFlvdXJzLCBEYW5pZWwKPiA+Cj4gPiBGb3IgcmVmZXJl bmNlIHRoZSBkaWZmLCBidXQgcHJvYmFibHkgd2hpdGVzcGFjZSBtYW5nbGVkIGJlY2F1c2UgdGhl Cj4gPiByZWFsIG1hY2hpbmUgaXMgZG93biBhbHJlYWR5Ogo+ID4KPiA+IGRpZmYgLS1naXQgYS9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9maWZvX3VuZGVycnVuLmMKPiA+IGIvZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfZmlmb191bmRlcnJ1bi5jCj4gPiBpbmRleCBkNDg0ODYyY2M3ZGYu LjIxYzIyMWI0YWU1NyAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X2ZpZm9fdW5kZXJydW4uYwo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZmlm b191bmRlcnJ1bi5jCj4gPiBAQCAtMzEzLDcgKzMxMyw3IEBAIGJvb2wgaW50ZWxfc2V0X2NwdV9m aWZvX3VuZGVycnVuX3JlcG9ydGluZyhzdHJ1Y3QKPiA+IGRybV9pOTE1X3ByaXZhdGUgKmRldl9w cml2LAo+ID4gICAqIFJldHVybnMgdGhlIHByZXZpb3VzIHN0YXRlIG9mIHVuZGVycnVuIHJlcG9y dGluZy4KPiA+ICAgKi8KPiA+ICBib29sIGludGVsX3NldF9wY2hfZmlmb191bmRlcnJ1bl9yZXBv cnRpbmcoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ID4gLSAgIGVudW0gdHJh bnNjb2RlciBwY2hfdHJhbnNjb2RlciwKPiA+ICsgICBlbnVtIHBpcGUgcGNoX3RyYW5zY29kZXIs Cj4gPiAgICAgYm9vbCBlbmFibGUpCj4gPiAgewo+ID4gICBzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0 YyA9Cj4gPiBAQCAtMzkwLDcgKzM5MCw3IEBAIHZvaWQgaW50ZWxfY3B1X2ZpZm9fdW5kZXJydW5f aXJxX2hhbmRsZXIoc3RydWN0Cj4gPiBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiA+ICAg KiBpbnRlcnJ1cHQgdG8gYXZvaWQgYW4gaXJxIHN0b3JtLgo+ID4gICAqLwo+ID4gIHZvaWQgaW50 ZWxfcGNoX2ZpZm9fdW5kZXJydW5faXJxX2hhbmRsZXIoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUg KmRldl9wcml2LAo+ID4gLSBlbnVtIHRyYW5zY29kZXIgcGNoX3RyYW5zY29kZXIpCj4gPiArIGVu dW0gcGlwZSBwY2hfdHJhbnNjb2RlcikKPiA+ICB7Cj4gPiAgIGlmIChpbnRlbF9zZXRfcGNoX2Zp Zm9fdW5kZXJydW5fcmVwb3J0aW5nKGRldl9wcml2LCBwY2hfdHJhbnNjb2RlciwKPiA+ICAgIGZh bHNlKSkgewo+ID4KPiA+Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9w Lm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVs LWdmeAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751194AbdGNXio (ORCPT ); Fri, 14 Jul 2017 19:38:44 -0400 Received: from mail-pf0-f171.google.com ([209.85.192.171]:33279 "EHLO mail-pf0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751004AbdGNXim (ORCPT ); Fri, 14 Jul 2017 19:38:42 -0400 Date: Fri, 14 Jul 2017 16:38:40 -0700 From: Matthias Kaehlcke To: Grant Grundler Cc: Daniel Vetter , Jani Nikula , intel-gfx , Linux Kernel Mailing List , "dri-devel@lists.freedesktop.org" , Michael Davidson , =?utf-8?B?U3TDqXBoYW5l?= Marchesin , Daniel Vetter Subject: Re: [Intel-gfx] [PATCH RESEND] drm/i915: Fix pipe/transcoder enum mismatches Message-ID: <20170714233840.GK95735@google.com> References: <20170505174043.GK12629@intel.com> <20170713101351.GS12629@intel.com> <20170713174232.GK12629@intel.com> <87eftjl6xg.fsf@nikula.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org El Fri, Jul 14, 2017 at 03:43:35PM -0700 Grant Grundler ha dit: > On Fri, Jul 14, 2017 at 2:35 PM, Daniel Vetter wrote: > > On Fri, Jul 14, 2017 at 7:32 PM, Grant Grundler wrote: > >> On Fri, Jul 14, 2017 at 2:11 AM, Jani Nikula > >> wrote: > >>> On Thu, 13 Jul 2017, Stéphane Marchesin wrote: > >>>> So, if you think this is wrong, can you fix this warning in a way that > >>>> you'd like? > >>> > >>> As I replied previously [1], with more background, fixing the warnings > >>> properly, in a way that actually improves the code instead of making it > >>> worse, would mean a bunch of churn that's not just purely mechanical > >>> conversion. > >> > >> That's fair. > >> > >>> Unless you can point out a bug which is actually caused by mixing the > >>> types (which is mostly intentional, see the background) I have a hard > >>> time telling people this should be a priority. > >> > >> This feels like "can't see the forest because of the trees". > >> > >> The original patch was submitted in order to compile cleanly using > >> clang and the above suggests using clang is not important. Using > >> clang is important to Matthias and the Chrome OS organization for many > >> good reasons - including better warnings. > >> > >> The original patch message was clear that clang was generating the > >> warning. This isn't the only patch mka has sent to kernel devs. What > >> one can infer is Chrome OS is trying to move to clang (like other > >> Google products _already_ have.) My impression is all these products > >> are a priority to Intel - but it would be good to know otherwise. > >> > >>> Definitely something we'd > >>> like to do in the long run and pedantically correct (and I tend to > >>> prefer code that way) but we certainly have more important things to do. > >> > >> The long run is now. Everyone agrees the code should change and you > >> don't have to do it. Matthias submitted an unacceptable patch and > >> giving him some concrete guidance on what would be acceptable would > >> enable him to implement/test it (or anyone else could for that > >> matter). Can you do that? > >> > >> Just give an example of what the "right" API looks like and see where it goes. > > > > We've replied and discussed on May 5th what that roughly should be, > > right when Matthias pinged us. The original submission unfortunately > > fell through the cracks (it happens, not much we can do with this > > flood). Matthias didn't seem to have any questions about the proposed > > solutions (we laid out both the minimal short-term fix to unconfuse > > things, and what might be done on top), I think a reasonable > > assumption was that it's all clear. Otherwise he should have asked. > > Indeed! > > After briefly chatting with Stephane and mka, it seems the difference > between short-term fix and "done on top" were not clear. > > > Now, over 2 months later (and complete silence from your side) there's > > suddenly mass panic and multiple escalations on all available > > channels, which feels like a rather decent overreaction and not a > > terrible constructive way to collaborate on the upstream codebase. > > I'm sorry - I'm not on the other channels and I didn't see any mass > panic. I agree that's not a collaborative. The previous answer in this > thread didn't seem particularly collaborative either though. > > The silence was partly due to mka working on other "clang enablement" patches: Yes, sorry for the silence :( With my lack of expertise with this driver and graphics in general I wasn't sure if I'd take up the "done on top" solution and shifted my attention to other clang related issues. > $ pwclient list -w mka@chromium.org > Patches submitted by Matthias Kaehlcke : > ID State Name > -- ----- ---- > 9668095 Superseded mac80211: Fix clang warning about constant > operand in logical operation > 9668479 Accepted ath9k: Add cast to u8 to FREQ2FBIN macro > 9668643 Accepted [v2] mac80211: Fix clang warning about constant > operand in logical operation > 9679753 Accepted [v2] cfg80211: Fix array-bounds warning in fragment copy > 9684547 Accepted mac80211: ibss: Fix channel type enum in > ieee80211_sta_join_ibss() > 9684629 Accepted nl80211: Fix enum type of variable in > nl80211_put_sta_rate() > > > Anyway, I've done the quick draft for the function declaration changes > > that would clear up the confusion, just needs a clang run to update > > all the parameters to match, and passed that on to Stéphane Marchesin. Thanks, that is helpful! > Awesome - thanks! :) > > > I expect you to follow up with the corresponding patch right away. > > mka said "he would take a look at it". But knowing how he understates > things in a typical "German Engineer" way, I'm optimistic it will be > more than that. Thanks! > > cheers, > grant > > > > > Thanks a lot. > > > > Yours, Daniel > > > > For reference the diff, but probably whitespace mangled because the > > real machine is down already: > > > > diff --git a/drivers/gpu/drm/i915/intel_fifo_underrun.c > > b/drivers/gpu/drm/i915/intel_fifo_underrun.c > > index d484862cc7df..21c221b4ae57 100644 > > --- a/drivers/gpu/drm/i915/intel_fifo_underrun.c > > +++ b/drivers/gpu/drm/i915/intel_fifo_underrun.c > > @@ -313,7 +313,7 @@ bool intel_set_cpu_fifo_underrun_reporting(struct > > drm_i915_private *dev_priv, > > * Returns the previous state of underrun reporting. > > */ > > bool intel_set_pch_fifo_underrun_reporting(struct drm_i915_private *dev_priv, > > - enum transcoder pch_transcoder, > > + enum pipe pch_transcoder, > > bool enable) > > { > > struct intel_crtc *crtc = > > @@ -390,7 +390,7 @@ void intel_cpu_fifo_underrun_irq_handler(struct > > drm_i915_private *dev_priv, > > * interrupt to avoid an irq storm. > > */ > > void intel_pch_fifo_underrun_irq_handler(struct drm_i915_private *dev_priv, > > - enum transcoder pch_transcoder) > > + enum pipe pch_transcoder) > > { > > if (intel_set_pch_fifo_underrun_reporting(dev_priv, pch_transcoder, > > false)) { > > > >