All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joseph Wright <rjosephwright@gmail.com>
To: gregkh@linuxfoundation.org, arve@android.com, riandrews@android.com
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
	Joseph Wright <rjosephwright@gmail.com>
Subject: [PATCH v3 1/1] Staging: android/ion: declare function static
Date: Sat, 15 Jul 2017 11:43:05 +0000	[thread overview]
Message-ID: <20170715114305.1336-2-rjosephwright@gmail.com> (raw)
In-Reply-To: <20170715114305.1336-1-rjosephwright@gmail.com>

Declare private function static to fix sparse warning:

ion_cma_heap.c:109:5: warning: symbol '__ion_add_cma_heaps' \
	was not declared. Should it be static?

Signed-off-by: Joseph Wright <rjosephwright@gmail.com>
---
Changes in v3:
  - Make subject clearer

 drivers/staging/android/ion/ion_cma_heap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/android/ion/ion_cma_heap.c b/drivers/staging/android/ion/ion_cma_heap.c
index a0949bc..c6db9b7 100644
--- a/drivers/staging/android/ion/ion_cma_heap.c
+++ b/drivers/staging/android/ion/ion_cma_heap.c
@@ -106,7 +106,7 @@ static struct ion_heap *__ion_cma_heap_create(struct cma *cma)
 	return &cma_heap->heap;
 }
 
-int __ion_add_cma_heaps(struct cma *cma, void *data)
+static int __ion_add_cma_heaps(struct cma *cma, void *data)
 {
 	struct ion_heap *heap;
 
-- 
2.9.3

  reply	other threads:[~2017-07-17 16:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-15 11:43 [PATCH v3 0/1] Staging: android/ion: fix sparse warnings Joseph Wright
2017-07-15 11:43 ` Joseph Wright [this message]
2017-07-18  6:58   ` [PATCH v3 1/1] Staging: android/ion: declare function static Greg KH
2017-07-18 15:00     ` Joseph Wright

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170715114305.1336-2-rjosephwright@gmail.com \
    --to=rjosephwright@gmail.com \
    --cc=arve@android.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=riandrews@android.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.