All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v6 1/4] infra: add support for MIPS NaN
Date: Sun, 16 Jul 2017 16:46:10 +0200	[thread overview]
Message-ID: <20170716164610.4d030529@windsurf> (raw)
In-Reply-To: <20170628151713.10746-1-Vincent.Riera@imgtec.com>

Hello,

On Wed, 28 Jun 2017 16:17:10 +0100, Vicente Olivert Riera wrote:

> +choice
> +	prompt "Target NaN"
> +	depends on BR2_mips_32r5 || BR2_mips_64r5
> +	default BR2_MIPS_ENABLE_NAN_2008
> +
> +	help
> +	  NaN encoding to be used

In fact, it would be good here to have a much more detailed help text,
perhaps by re-using bits of your commit log.

Same for the FP32 patch.

Could you send follow-up patches improving those help texts?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

      parent reply	other threads:[~2017-07-16 14:46 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-28 15:17 [Buildroot] [PATCH v6 1/4] infra: add support for MIPS NaN Vicente Olivert Riera
2017-06-28 15:17 ` [Buildroot] [PATCH v6 2/4] infra: add support for MIPS32 FP mode Vicente Olivert Riera
2017-07-16 15:32   ` Thomas Petazzoni
2017-06-28 15:17 ` [Buildroot] [PATCH v6 3/4] infra: add MIPS DSP support Vicente Olivert Riera
2017-06-28 15:17 ` [Buildroot] [PATCH v6 4/4] infra: add support for MIPS MSA Vicente Olivert Riera
2017-07-16 14:40 ` [Buildroot] [PATCH v6 1/4] infra: add support for MIPS NaN Thomas Petazzoni
2017-07-17  9:34   ` Thomas Petazzoni
2017-07-17 12:03     ` Vicente Olivert Riera
2017-07-17 12:11       ` Thomas Petazzoni
2017-07-18 10:40         ` Vicente Olivert Riera
2017-07-16 14:46 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170716164610.4d030529@windsurf \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.