[PATCH] irqchip/gic: Use GIC_SPI symbolic constant

[thomas.petazzoni@free-electrons.com (Thomas Petazzoni)]

Hello,

On Sun, 16 Jul 2017 22:08:01 +0100, Marc Zyngier wrote:

> > Are you saying that changing the code at this point is
> > not worth the trouble?  
> 
> You're assuming that this GIC_SPI macro has anything to do with the GIC
> driver. It doesn't. That's just a convenience macro for people writing
> DT, and definitely not something I'd ever want to rely on in the Linux
> driver. The binding defines the raw value, and not this macro.
> 
> So to sum it up, thank you, but no thank out.

FWIW, a few drivers are already using GIC_SPI:

irq-mvebu-gicp.c:       fwspec.param[0] = GIC_SPI;
irq-mvebu-odmi.c:       fwspec.param[0] = GIC_SPI;
irq-tegra.c:    if (fwspec->param[0] != GIC_SPI)
irq-vf610-mscm-ir.c:            parent_fwspec.param[0] = GIC_SPI;

For pretty much exactly the situation being patched by Mason.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com