From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH 7/7] nvme: Send change uevent when AEN completes
Date: Mon, 17 Jul 2017 11:22:32 -0400 [thread overview]
Message-ID: <20170717152232.GC24365@localhost.localdomain> (raw)
In-Reply-To: <20170715084218.GA23189@lst.de>
On Sat, Jul 15, 2017@10:42:18AM +0200, Christoph Hellwig wrote:
>
> Take the Changed Namespace List log page for example.
>
> We get an AER, and then both schedule a log page read in the kernel
> (as we should, patch pending) and send the uevent. As soon as the
> read the log page in the kernel to clear the log page we get another
> event due to another namespace change, but not userspace manages to
> read the log page before the kernel acts on the next AER, so the
> kernel won't see the changes.
>
> And yes, this is probably a little constructed, but we'll get more
> log pages with similar semantics, so I am worried a bit about this.
That event needs to already be handled by the driver without relying
on the Changed Namespace List log, like when the list exceeds the log
size. But okay, I see the concern in general if reading a log page may
change the results.
next prev parent reply other threads:[~2017-07-17 15:22 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-07 16:22 [PATCH 0/7] NVMe Async Event Notification updates Keith Busch
2017-07-07 16:22 ` [PATCH 1/7] nvme/fc: There is only one AEN request Keith Busch
2017-07-10 23:12 ` James Smart
2017-07-07 16:22 ` [PATCH 2/7] nvme/fc: Fix admin queue depth setup Keith Busch
2017-07-10 5:59 ` Sagi Grimberg
2017-07-10 22:57 ` Keith Busch
2017-07-10 23:40 ` James Smart
2017-07-10 23:49 ` James Smart
2017-07-07 16:22 ` [PATCH 3/7] nvme/fc: remove unused "queue_size" field Keith Busch
2017-07-10 6:00 ` Sagi Grimberg
2017-07-10 23:44 ` James Smart
2017-07-07 16:22 ` [PATCH 4/7] nvme: Centralize blk-mq tag and AEN counts Keith Busch
2017-07-10 6:01 ` Sagi Grimberg
2017-07-10 23:51 ` James Smart
2017-07-07 16:22 ` [PATCH 5/7] nvme: Only one AEN request Keith Busch
2017-07-10 6:06 ` Sagi Grimberg
2017-07-10 23:53 ` James Smart
2017-07-07 16:23 ` [PATCH 6/7] nvme: Unexport starting async event work Keith Busch
2017-07-07 18:11 ` Christoph Hellwig
2017-07-07 19:54 ` Keith Busch
2017-07-07 16:23 ` [PATCH 7/7] nvme: Send change uevent when AEN completes Keith Busch
2017-07-07 18:14 ` Christoph Hellwig
2017-07-13 21:29 ` Keith Busch
2017-07-14 12:50 ` Guilherme G. Piccoli
2017-07-14 12:54 ` Christoph Hellwig
2017-07-14 12:53 ` Christoph Hellwig
2017-07-14 15:16 ` Keith Busch
2017-07-15 8:42 ` Christoph Hellwig
2017-07-17 15:22 ` Keith Busch [this message]
2017-08-01 11:59 ` Guan Junxiong
2017-07-10 10:17 ` Zou Ming
2017-07-10 17:38 ` Keith Busch
2017-07-10 23:57 ` James Smart
2017-07-11 14:43 ` Keith Busch
2017-07-11 17:14 ` James Smart
2017-07-13 16:09 ` Keith Busch
2017-07-07 18:09 ` [PATCH 0/7] NVMe Async Event Notification updates Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170717152232.GC24365@localhost.localdomain \
--to=keith.busch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.