From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lothar =?UTF-8?B?V2HDn21hbm4=?= Subject: Re: [PATCH v2 0/5] thermal: imx: Add nvmem-cells binding on imx6sx Date: Mon, 17 Jul 2017 16:00:22 +0200 Message-ID: <20170717160022.6892b839@karo-electronics.de> References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Leonard Crestez Cc: Srinivas Kandagatla , Shawn Guo , Rob Herring , Zhang Rui , Eduardo Valentin , Mark Rutland , Dong Aisheng , Bai Ping , Anson Huang , Octavian Purdila , Fabio Estevam , linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-pm@vger.kernel.org Hi, On Fri, 14 Jul 2017 17:11:05 +0300 Leonard Crestez wrote: > On imx6sx accessing OCOTP directly is wrong because the ocotp clock needs to be > enabled first. Fix this by adding a nvmem-cells binding and using it on imx6sx, > imx6ul and imx6ull. > > The existing binding is kept around because it works fine on imx6qdl. > > This was initially reported by Lothar Waßmann in reply > to a patch adding imx6ul/ull support: > > Link: https://lkml.org/lkml/2017/6/9/578 > > --- > Changes since v1: > * Move nvmem_cell_read_u32 to nvmem core (Shawn Guo, Srinivas Kandagatla) > * Adjust binding description (Rob Herring) > * Adjust formatting of thermal info cells (Shawn Guo) > * Link: https://lkml.org/lkml/2017/7/6/426 > > Leonard Crestez (5): > thermal: imx: Add nvmem-cells alternate binding for OCOTP access > nvmem: core: Add nvmem_cell_read_u32 > thermal: imx: Add support for reading OCOTP through nvmem > ARM: dts: imx6sx: Use nvmem-cells for tempmon > ARM: dts: imx6ul: Add imx6ul-tempmon > > .../devicetree/bindings/thermal/imx-thermal.txt | 7 ++ > arch/arm/boot/dts/imx6sx.dtsi | 13 ++- > arch/arm/boot/dts/imx6ul.dtsi | 19 ++++ > drivers/nvmem/core.c | 37 ++++++++ > drivers/thermal/imx_thermal.c | 103 +++++++++++++++------ > include/linux/nvmem-consumer.h | 8 ++ > 6 files changed, 156 insertions(+), 31 deletions(-) > Works as expected on TX6UL-5010. Tested-By: Lothar Waßmann Lothar Waßmann From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751378AbdGQOAh convert rfc822-to-8bit (ORCPT ); Mon, 17 Jul 2017 10:00:37 -0400 Received: from smtprelay04.ispgateway.de ([80.67.31.42]:49285 "EHLO smtprelay04.ispgateway.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751278AbdGQOAg (ORCPT ); Mon, 17 Jul 2017 10:00:36 -0400 Date: Mon, 17 Jul 2017 16:00:22 +0200 From: Lothar =?UTF-8?B?V2HDn21hbm4=?= To: Leonard Crestez Cc: Srinivas Kandagatla , Shawn Guo , Rob Herring , Zhang Rui , Eduardo Valentin , Mark Rutland , Dong Aisheng , Bai Ping , Anson Huang , Octavian Purdila , Fabio Estevam , , , Subject: Re: [PATCH v2 0/5] thermal: imx: Add nvmem-cells binding on imx6sx Message-ID: <20170717160022.6892b839@karo-electronics.de> In-Reply-To: References: Organization: Ka-Ro electronics GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT X-Df-Sender: bHdAa2Fyby1lbGVjdHJvbmljcy5kZQ== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Fri, 14 Jul 2017 17:11:05 +0300 Leonard Crestez wrote: > On imx6sx accessing OCOTP directly is wrong because the ocotp clock needs to be > enabled first. Fix this by adding a nvmem-cells binding and using it on imx6sx, > imx6ul and imx6ull. > > The existing binding is kept around because it works fine on imx6qdl. > > This was initially reported by Lothar Waßmann in reply > to a patch adding imx6ul/ull support: > > Link: https://lkml.org/lkml/2017/6/9/578 > > --- > Changes since v1: > * Move nvmem_cell_read_u32 to nvmem core (Shawn Guo, Srinivas Kandagatla) > * Adjust binding description (Rob Herring) > * Adjust formatting of thermal info cells (Shawn Guo) > * Link: https://lkml.org/lkml/2017/7/6/426 > > Leonard Crestez (5): > thermal: imx: Add nvmem-cells alternate binding for OCOTP access > nvmem: core: Add nvmem_cell_read_u32 > thermal: imx: Add support for reading OCOTP through nvmem > ARM: dts: imx6sx: Use nvmem-cells for tempmon > ARM: dts: imx6ul: Add imx6ul-tempmon > > .../devicetree/bindings/thermal/imx-thermal.txt | 7 ++ > arch/arm/boot/dts/imx6sx.dtsi | 13 ++- > arch/arm/boot/dts/imx6ul.dtsi | 19 ++++ > drivers/nvmem/core.c | 37 ++++++++ > drivers/thermal/imx_thermal.c | 103 +++++++++++++++------ > include/linux/nvmem-consumer.h | 8 ++ > 6 files changed, 156 insertions(+), 31 deletions(-) > Works as expected on TX6UL-5010. Tested-By: Lothar Waßmann Lothar Waßmann