From mboxrd@z Thu Jan 1 00:00:00 1970 From: Manasi Navare Subject: Re: [PATCH] drm/i915: Return correct EDP voltage swing table for 0.85V Date: Mon, 17 Jul 2017 12:21:20 -0700 Message-ID: <20170717192119.GE20790@intel.com> References: <20170717182127.59072-1-mka@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20170717182127.59072-1-mka@chromium.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Matthias Kaehlcke Cc: =?iso-8859-1?Q?St=E9phane?= Marchesin , David Airlie , intel-gfx , Linux Kernel Mailing List , Grant Grundler , dri-devel@lists.freedesktop.org, Daniel Vetter List-Id: dri-devel@lists.freedesktop.org VGhpcyBtYWtlcyBzZW5zZSwgaXQgc2hvdWxkIGhhdmUgcmV0dXJuZWQgdGhlIGVkcCBkZGkgYnVm IHRyYW5zbGF0aW9uCnRhYmxlIGFzIHBlciB0aGUgQnNwZWMuClBsZWFzZSBhZGQgdGhpcyB0byB0 aGUgY29tbWl0IG1lc3NhZ2U6CkZpeGVzOiBjZjU0Y2E4YmM1NjcgKCJkcm0vaTkxNS9jbmw6IElt cGxlbWVudCB2b2x0YWdlIHN3aW5nIHNlcXVlbmNlLiIpCgpBZnRlciB0aGF0LApSZXZpZXdlZC1i eTogTWFuYXNpIE5hdmFyZSA8bWFuYXNpLmQubmF2YXJlQGludGVsLmNvbT4KCk1hbmFzaQoKCk9u IE1vbiwgSnVsIDE3LCAyMDE3IGF0IDExOjIxOjI3QU0gLTA3MDAsIE1hdHRoaWFzIEthZWhsY2tl IHdyb3RlOgo+IEZvciAwLjg1ViBjbmxfZ2V0X2J1Zl90cmFuc19lZHAoKSByZXR1cm5zIHRoZSBE UCB0YWJsZSwgaW5zdGVhZCBvZiBFRFAuCj4gVXNlIHRoZSBjb3JyZWN0IHRhYmxlLgo+IAo+IFRo ZSBlcnJvciB3YXMgcG9pbnRlZCBvdXQgYnkgdGhpcyBjbGFuZyB3YXJuaW5nOgo+IAo+IGRyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2RkaS5jOjM5MjozOTogd2FybmluZzogdmFyaWFibGUKPiAg ICdjbmxfZGRpX3RyYW5zbGF0aW9uc19lZHBfMF84NVYnIGlzIG5vdCBuZWVkZWQgYW5kIHdpbGwg bm90IGJlIGVtaXR0ZWQKPiAgIFstV3VubmVlZGVkLWludGVybmFsLWRlY2xhcmF0aW9uXQo+ICAg ICBzdGF0aWMgY29uc3Qgc3RydWN0IGNubF9kZGlfYnVmX3RyYW5zIGNubF9kZGlfdHJhbnNsYXRp b25zX2VkcF8wXzg1VltdID0gewo+IAo+IFNpZ25lZC1vZmYtYnk6IE1hdHRoaWFzIEthZWhsY2tl IDxta2FAY2hyb21pdW0ub3JnPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9k ZGkuYyB8IDIgKy0KPiAgMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9u KC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RkaS5jIGIv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGRpLmMKPiBpbmRleCBlZmIxMzU4MmRjNzMuLjZm YTAyZTZhN2E5YiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kZGku Ywo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RkaS5jCj4gQEAgLTE4NzMsNyAr MTg3Myw3IEBAIGNubF9nZXRfYnVmX3RyYW5zX2VkcChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAq ZGV2X3ByaXYsCj4gIAlpZiAoZGV2X3ByaXYtPnZidC5lZHAubG93X3Zzd2luZykgewo+ICAJCWlm ICh2b2x0YWdlID09IFZPTFRBR0VfSU5GT18wXzg1Vikgewo+ICAJCQkqbl9lbnRyaWVzID0gQVJS QVlfU0laRShjbmxfZGRpX3RyYW5zbGF0aW9uc19lZHBfMF84NVYpOwo+IC0JCQlyZXR1cm4gY25s X2RkaV90cmFuc2xhdGlvbnNfZHBfMF84NVY7Cj4gKwkJCXJldHVybiBjbmxfZGRpX3RyYW5zbGF0 aW9uc19lZHBfMF84NVY7Cj4gIAkJfSBlbHNlIGlmICh2b2x0YWdlID09IFZPTFRBR0VfSU5GT18w Xzk1Vikgewo+ICAJCQkqbl9lbnRyaWVzID0gQVJSQVlfU0laRShjbmxfZGRpX3RyYW5zbGF0aW9u c19lZHBfMF85NVYpOwo+ICAJCQlyZXR1cm4gY25sX2RkaV90cmFuc2xhdGlvbnNfZWRwXzBfOTVW Owo+IC0tIAo+IDIuMTMuMi45MzIuZzc0NDllOTY0Yy1nb29nCj4gCj4gX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBJbnRlbC1nZnggbWFpbGluZyBsaXN0 Cj4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJlZWRl c2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwt Z2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751351AbdGQTOc (ORCPT ); Mon, 17 Jul 2017 15:14:32 -0400 Received: from mga01.intel.com ([192.55.52.88]:50130 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751311AbdGQTOb (ORCPT ); Mon, 17 Jul 2017 15:14:31 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,375,1496127600"; d="scan'208";a="1152431826" Date: Mon, 17 Jul 2017 12:21:20 -0700 From: Manasi Navare To: Matthias Kaehlcke Cc: Daniel Vetter , Jani Nikula , David Airlie , Daniel Vetter , Grant Grundler , intel-gfx , Linux Kernel Mailing List , dri-devel@lists.freedesktop.org, =?iso-8859-1?Q?St=E9phane?= Marchesin Subject: Re: [Intel-gfx] [PATCH] drm/i915: Return correct EDP voltage swing table for 0.85V Message-ID: <20170717192119.GE20790@intel.com> References: <20170717182127.59072-1-mka@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170717182127.59072-1-mka@chromium.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This makes sense, it should have returned the edp ddi buf translation table as per the Bspec. Please add this to the commit message: Fixes: cf54ca8bc567 ("drm/i915/cnl: Implement voltage swing sequence.") After that, Reviewed-by: Manasi Navare Manasi On Mon, Jul 17, 2017 at 11:21:27AM -0700, Matthias Kaehlcke wrote: > For 0.85V cnl_get_buf_trans_edp() returns the DP table, instead of EDP. > Use the correct table. > > The error was pointed out by this clang warning: > > drivers/gpu/drm/i915/intel_ddi.c:392:39: warning: variable > 'cnl_ddi_translations_edp_0_85V' is not needed and will not be emitted > [-Wunneeded-internal-declaration] > static const struct cnl_ddi_buf_trans cnl_ddi_translations_edp_0_85V[] = { > > Signed-off-by: Matthias Kaehlcke > --- > drivers/gpu/drm/i915/intel_ddi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c > index efb13582dc73..6fa02e6a7a9b 100644 > --- a/drivers/gpu/drm/i915/intel_ddi.c > +++ b/drivers/gpu/drm/i915/intel_ddi.c > @@ -1873,7 +1873,7 @@ cnl_get_buf_trans_edp(struct drm_i915_private *dev_priv, > if (dev_priv->vbt.edp.low_vswing) { > if (voltage == VOLTAGE_INFO_0_85V) { > *n_entries = ARRAY_SIZE(cnl_ddi_translations_edp_0_85V); > - return cnl_ddi_translations_dp_0_85V; > + return cnl_ddi_translations_edp_0_85V; > } else if (voltage == VOLTAGE_INFO_0_95V) { > *n_entries = ARRAY_SIZE(cnl_ddi_translations_edp_0_95V); > return cnl_ddi_translations_edp_0_95V; > -- > 2.13.2.932.g7449e964c-goog > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx