From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from szxga03-in.huawei.com ([45.249.212.189]:8929 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751279AbdGQLuN (ORCPT ); Mon, 17 Jul 2017 07:50:13 -0400 Date: Mon, 17 Jul 2017 19:49:54 +0800 From: Jonathan Cameron To: Lorenzo Bianconi CC: Jonathan Cameron , Rob Herring , Jonathan Cameron , "linux-iio@vger.kernel.org" , "devicetree@vger.kernel.org" , Lorenzo BIANCONI Subject: Re: [PATCH 8/9] dt-bindings: iio: humidity: hts221: support open drain mode Message-ID: <20170717194954.00004b62@huawei.com> In-Reply-To: References: <20170709165704.26311-1-lorenzo.bianconi@st.com> <20170709165704.26311-9-lorenzo.bianconi@st.com> <20170711025158.vpt6bcznkhi3bslm@rob-hp-laptop> <20170711192656.7fd08a1c@kernel.org> <0462CB71-6762-48F2-99B3-EA62FF81C280@jic23.retrosnub.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On Sat, 15 Jul 2017 16:32:35 +0200 Lorenzo Bianconi wrote: > > > > > > On 11 July 2017 19:42:54 BST, Rob Herring wrote: > >>On Tue, Jul 11, 2017 at 1:26 PM, Jonathan Cameron > >>wrote: > >>> On Mon, 10 Jul 2017 21:51:58 -0500 > >>> Rob Herring wrote: > >>> > >>>> On Sun, Jul 09, 2017 at 06:57:03PM +0200, Lorenzo Bianconi wrote: > >>>> > Signed-off-by: Lorenzo Bianconi > >>>> > --- > >>>> > Documentation/devicetree/bindings/iio/humidity/hts221.txt | 8 > >>++++++++ > >>>> > 1 file changed, 8 insertions(+) > >>>> > > >>>> > diff --git > >>a/Documentation/devicetree/bindings/iio/humidity/hts221.txt > >>b/Documentation/devicetree/bindings/iio/humidity/hts221.txt > >>>> > index fca263e13400..732b83c06c08 100644 > >>>> > --- a/Documentation/devicetree/bindings/iio/humidity/hts221.txt > >>>> > +++ b/Documentation/devicetree/bindings/iio/humidity/hts221.txt > >>>> > @@ -5,6 +5,14 @@ Required properties: > >>>> > - reg: i2c address of the sensor / spi cs line > >>>> > > >>>> > Optional properties: > >>>> > +- drive-open-drain: the interrupt/data ready line will be > >>configured > >>>> > >>>> Needs a vendor prefix and "drdy-open-drain" would be more specific. > >>> This is straight out of the pinctrl bindings and has been used in a > >>few > >>> other places as well. I can see it should really be more obviously > >>> associated with the drdy pin though. A few IIO drivers already > >>> use this binding (st sensors and the lsm6dsx). If we are going > >>> to decide it's a bad idea we should deprecate those bindings and > >>> add whatever we do here as well. > >> > >>Ah, okay. Then the description should have a "see pinctrl.txt" for > >>the description. > > Agreed. > > This property has been defined in pinctrl/pinctrl-bindings.txt. Is it > fine to refer to that file? > Regards, > Lorenzo Yes, that's what Rob was effectively suggesting. > > >> > >>Rob > >>-- > >>To unsubscribe from this list: send the line "unsubscribe linux-iio" in > >>the body of a message to majordomo@vger.kernel.org > >>More majordomo info at http://vger.kernel.org/majordomo-info.html > > > > -- > > Sent from my Android device with K-9 Mail. Please excuse my brevity. > > > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jonathan Cameron Subject: Re: [PATCH 8/9] dt-bindings: iio: humidity: hts221: support open drain mode Date: Mon, 17 Jul 2017 19:49:54 +0800 Message-ID: <20170717194954.00004b62@huawei.com> References: <20170709165704.26311-1-lorenzo.bianconi@st.com> <20170709165704.26311-9-lorenzo.bianconi@st.com> <20170711025158.vpt6bcznkhi3bslm@rob-hp-laptop> <20170711192656.7fd08a1c@kernel.org> <0462CB71-6762-48F2-99B3-EA62FF81C280@jic23.retrosnub.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-iio-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Lorenzo Bianconi Cc: Jonathan Cameron , Rob Herring , Jonathan Cameron , "linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Lorenzo BIANCONI List-Id: devicetree@vger.kernel.org On Sat, 15 Jul 2017 16:32:35 +0200 Lorenzo Bianconi wrote: > > > > > > On 11 July 2017 19:42:54 BST, Rob Herring wrote: > >>On Tue, Jul 11, 2017 at 1:26 PM, Jonathan Cameron > >>wrote: > >>> On Mon, 10 Jul 2017 21:51:58 -0500 > >>> Rob Herring wrote: > >>> > >>>> On Sun, Jul 09, 2017 at 06:57:03PM +0200, Lorenzo Bianconi wrote: > >>>> > Signed-off-by: Lorenzo Bianconi > >>>> > --- > >>>> > Documentation/devicetree/bindings/iio/humidity/hts221.txt | 8 > >>++++++++ > >>>> > 1 file changed, 8 insertions(+) > >>>> > > >>>> > diff --git > >>a/Documentation/devicetree/bindings/iio/humidity/hts221.txt > >>b/Documentation/devicetree/bindings/iio/humidity/hts221.txt > >>>> > index fca263e13400..732b83c06c08 100644 > >>>> > --- a/Documentation/devicetree/bindings/iio/humidity/hts221.txt > >>>> > +++ b/Documentation/devicetree/bindings/iio/humidity/hts221.txt > >>>> > @@ -5,6 +5,14 @@ Required properties: > >>>> > - reg: i2c address of the sensor / spi cs line > >>>> > > >>>> > Optional properties: > >>>> > +- drive-open-drain: the interrupt/data ready line will be > >>configured > >>>> > >>>> Needs a vendor prefix and "drdy-open-drain" would be more specific. > >>> This is straight out of the pinctrl bindings and has been used in a > >>few > >>> other places as well. I can see it should really be more obviously > >>> associated with the drdy pin though. A few IIO drivers already > >>> use this binding (st sensors and the lsm6dsx). If we are going > >>> to decide it's a bad idea we should deprecate those bindings and > >>> add whatever we do here as well. > >> > >>Ah, okay. Then the description should have a "see pinctrl.txt" for > >>the description. > > Agreed. > > This property has been defined in pinctrl/pinctrl-bindings.txt. Is it > fine to refer to that file? > Regards, > Lorenzo Yes, that's what Rob was effectively suggesting. > > >> > >>Rob > >>-- > >>To unsubscribe from this list: send the line "unsubscribe linux-iio" in > >>the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > >>More majordomo info at http://vger.kernel.org/majordomo-info.html > > > > -- > > Sent from my Android device with K-9 Mail. Please excuse my brevity. > > >