From mboxrd@z Thu Jan 1 00:00:00 1970 From: Manasi Navare Subject: Re: [Intel-gfx] [PATCH] drm/i915: Return correct EDP voltage swing table for 0.85V Date: Mon, 17 Jul 2017 14:17:13 -0700 Message-ID: <20170717211713.GA6173@intel.com> References: <20170717182127.59072-1-mka@chromium.org> <1500318919.18069.5.camel@dk-H97M-D3H> <1500326360.18069.12.camel@dk-H97M-D3H> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <1500326360.18069.12.camel@dk-H97M-D3H> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: "Pandiyan, Dhinakaran" Cc: "grundler@chromium.org" , "intel-gfx@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "mka@chromium.org" , "Vivi, Rodrigo" , "Vetter, Daniel" List-Id: dri-devel@lists.freedesktop.org T24gTW9uLCBKdWwgMTcsIDIwMTcgYXQgMDg6NTk6MThQTSArMDAwMCwgUGFuZGl5YW4sIERoaW5h a2FyYW4gd3JvdGU6Cj4gCj4gCj4gCj4gT24gTW9uLCAyMDE3LTA3LTE3IGF0IDE4OjU1ICswMDAw LCBQYW5kaXlhbiwgRGhpbmFrYXJhbiB3cm90ZToKPiA+IExvb2tzIGxpa2UgYSB0eXBvIGluIAo+ ID4gCj4gPiBjZjU0Y2E4ICgiZHJtL2k5MTUvY25sOiBJbXBsZW1lbnQgdm9sdGFnZSBzd2luZyBz ZXF1ZW5jZS4iKQo+ID4gCj4gPiBidXQgQ2MnaW5nIFJvZHJpZ28sIENsaW50IHRvIG1ha2Ugc3Vy ZSB0aGlzIHdhc24ndCBhIHdvcmthcm91bmQuCj4gPiAKPiA+IC1ESwo+IAo+IENoZWNrZWQgd2l0 aCBDbGludCwgdGhpcyB3YXNuJ3QgYSB3b3JrYXJvdW5kLCBhIHR5cG8gaW5kZWVkLgo+IAo+CgpZ dXAsIExpa2UgSSBtZW50aW9uZWQgaW4gdGhlIHByZXZpb3VzIHJlcGx5LCBJIGFtIHBvc2l0aXZl IHRoYXQgdGhpcyBzaG91bGQKcmV0dXJuIGNubF9kZGlfdHJhbnNsYXRpb25zX2VkcF8wXzg1IHNp bmNlIEkgaGFkIGRpc2N1c3NlZCB0aGlzIHdpdGggUm9kcmlnbwp3aGlsZSB3b3JraW5nIG9uIGRk aSBidWZmZXIgaW5pdGlhbGl6YXRpb24uCgpNYXR0aGlhcywgcGxlYXNlIGdvIGFoZWFkIGFuZCBh ZGQgdGhlIEZpeGVzIFRhZyBsaWtlIEkgbWVudGlvbmVkIGluIG15IHByZXZpb3VzCm1lc3NhZ2Uu IFRoYW5rcyBmb3IgY2F0Y2hpbmcgdGhpcy4KCk1hbmFzaQoKCj4gCj4gPiBPbiBNb24sIDIwMTct MDctMTcgYXQgMTE6MjEgLTA3MDAsIE1hdHRoaWFzIEthZWhsY2tlIHdyb3RlOgo+ID4gPiBGb3Ig MC44NVYgY25sX2dldF9idWZfdHJhbnNfZWRwKCkgcmV0dXJucyB0aGUgRFAgdGFibGUsIGluc3Rl YWQgb2YgRURQLgo+ID4gPiBVc2UgdGhlIGNvcnJlY3QgdGFibGUuCj4gPiA+IAo+ID4gPiBUaGUg ZXJyb3Igd2FzIHBvaW50ZWQgb3V0IGJ5IHRoaXMgY2xhbmcgd2FybmluZzoKPiA+ID4gCj4gPiA+ IGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RkaS5jOjM5MjozOTogd2FybmluZzogdmFyaWFi bGUKPiA+ID4gICAnY25sX2RkaV90cmFuc2xhdGlvbnNfZWRwXzBfODVWJyBpcyBub3QgbmVlZGVk IGFuZCB3aWxsIG5vdCBiZSBlbWl0dGVkCj4gPiA+ICAgWy1XdW5uZWVkZWQtaW50ZXJuYWwtZGVj bGFyYXRpb25dCj4gPiA+ICAgICBzdGF0aWMgY29uc3Qgc3RydWN0IGNubF9kZGlfYnVmX3RyYW5z IGNubF9kZGlfdHJhbnNsYXRpb25zX2VkcF8wXzg1VltdID0gewo+ID4gPiAKPiA+ID4gU2lnbmVk LW9mZi1ieTogTWF0dGhpYXMgS2FlaGxja2UgPG1rYUBjaHJvbWl1bS5vcmc+Cj4gPiA+IC0tLQo+ ID4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGRpLmMgfCAyICstCj4gPiA+ICAxIGZp bGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkKPiA+ID4gCj4gPiA+IGRp ZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kZGkuYyBiL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX2RkaS5jCj4gPiA+IGluZGV4IGVmYjEzNTgyZGM3My4uNmZhMDJlNmE3 YTliIDEwMDY0NAo+ID4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kZGkuYwo+ ID4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kZGkuYwo+ID4gPiBAQCAtMTg3 Myw3ICsxODczLDcgQEAgY25sX2dldF9idWZfdHJhbnNfZWRwKHN0cnVjdCBkcm1faTkxNV9wcml2 YXRlICpkZXZfcHJpdiwKPiA+ID4gIAlpZiAoZGV2X3ByaXYtPnZidC5lZHAubG93X3Zzd2luZykg ewo+ID4gPiAgCQlpZiAodm9sdGFnZSA9PSBWT0xUQUdFX0lORk9fMF84NVYpIHsKPiA+ID4gIAkJ CSpuX2VudHJpZXMgPSBBUlJBWV9TSVpFKGNubF9kZGlfdHJhbnNsYXRpb25zX2VkcF8wXzg1Vik7 Cj4gPiA+IC0JCQlyZXR1cm4gY25sX2RkaV90cmFuc2xhdGlvbnNfZHBfMF84NVY7Cj4gPiA+ICsJ CQlyZXR1cm4gY25sX2RkaV90cmFuc2xhdGlvbnNfZWRwXzBfODVWOwo+ID4gPiAgCQl9IGVsc2Ug aWYgKHZvbHRhZ2UgPT0gVk9MVEFHRV9JTkZPXzBfOTVWKSB7Cj4gPiA+ICAJCQkqbl9lbnRyaWVz ID0gQVJSQVlfU0laRShjbmxfZGRpX3RyYW5zbGF0aW9uc19lZHBfMF85NVYpOwo+ID4gPiAgCQkJ cmV0dXJuIGNubF9kZGlfdHJhbnNsYXRpb25zX2VkcF8wXzk1VjsKPiA+IF9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gPiBJbnRlbC1nZnggbWFpbGluZyBs aXN0Cj4gPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gPiBodHRwczovL2xpc3Rz LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo+IF9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gZHJpLWRldmVsIG1haWxpbmcg bGlzdAo+IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwczovL2xpc3RzLmZy ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbApfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRy aS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5v cmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751474AbdGQVK0 (ORCPT ); Mon, 17 Jul 2017 17:10:26 -0400 Received: from mga03.intel.com ([134.134.136.65]:65436 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751335AbdGQVKZ (ORCPT ); Mon, 17 Jul 2017 17:10:25 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,375,1496127600"; d="scan'208";a="994030675" Date: Mon, 17 Jul 2017 14:17:13 -0700 From: Manasi Navare To: "Pandiyan, Dhinakaran" Cc: "mka@chromium.org" , "grundler@chromium.org" , "intel-gfx@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "Vivi, Rodrigo" , "Vetter, Daniel" Subject: Re: [Intel-gfx] [PATCH] drm/i915: Return correct EDP voltage swing table for 0.85V Message-ID: <20170717211713.GA6173@intel.com> References: <20170717182127.59072-1-mka@chromium.org> <1500318919.18069.5.camel@dk-H97M-D3H> <1500326360.18069.12.camel@dk-H97M-D3H> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1500326360.18069.12.camel@dk-H97M-D3H> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 17, 2017 at 08:59:18PM +0000, Pandiyan, Dhinakaran wrote: > > > > On Mon, 2017-07-17 at 18:55 +0000, Pandiyan, Dhinakaran wrote: > > Looks like a typo in > > > > cf54ca8 ("drm/i915/cnl: Implement voltage swing sequence.") > > > > but Cc'ing Rodrigo, Clint to make sure this wasn't a workaround. > > > > -DK > > Checked with Clint, this wasn't a workaround, a typo indeed. > > Yup, Like I mentioned in the previous reply, I am positive that this should return cnl_ddi_translations_edp_0_85 since I had discussed this with Rodrigo while working on ddi buffer initialization. Matthias, please go ahead and add the Fixes Tag like I mentioned in my previous message. Thanks for catching this. Manasi > > > On Mon, 2017-07-17 at 11:21 -0700, Matthias Kaehlcke wrote: > > > For 0.85V cnl_get_buf_trans_edp() returns the DP table, instead of EDP. > > > Use the correct table. > > > > > > The error was pointed out by this clang warning: > > > > > > drivers/gpu/drm/i915/intel_ddi.c:392:39: warning: variable > > > 'cnl_ddi_translations_edp_0_85V' is not needed and will not be emitted > > > [-Wunneeded-internal-declaration] > > > static const struct cnl_ddi_buf_trans cnl_ddi_translations_edp_0_85V[] = { > > > > > > Signed-off-by: Matthias Kaehlcke > > > --- > > > drivers/gpu/drm/i915/intel_ddi.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c > > > index efb13582dc73..6fa02e6a7a9b 100644 > > > --- a/drivers/gpu/drm/i915/intel_ddi.c > > > +++ b/drivers/gpu/drm/i915/intel_ddi.c > > > @@ -1873,7 +1873,7 @@ cnl_get_buf_trans_edp(struct drm_i915_private *dev_priv, > > > if (dev_priv->vbt.edp.low_vswing) { > > > if (voltage == VOLTAGE_INFO_0_85V) { > > > *n_entries = ARRAY_SIZE(cnl_ddi_translations_edp_0_85V); > > > - return cnl_ddi_translations_dp_0_85V; > > > + return cnl_ddi_translations_edp_0_85V; > > > } else if (voltage == VOLTAGE_INFO_0_95V) { > > > *n_entries = ARRAY_SIZE(cnl_ddi_translations_edp_0_95V); > > > return cnl_ddi_translations_edp_0_95V; > > _______________________________________________ > > Intel-gfx mailing list > > Intel-gfx@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel