From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56681) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dXHE9-0004qt-K9 for qemu-devel@nongnu.org; Mon, 17 Jul 2017 21:23:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dXHE6-0003dz-Hi for qemu-devel@nongnu.org; Mon, 17 Jul 2017 21:23:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58050) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dXHE6-0003dY-B6 for qemu-devel@nongnu.org; Mon, 17 Jul 2017 21:23:02 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5A68F85376 for ; Tue, 18 Jul 2017 01:23:01 +0000 (UTC) Date: Tue, 18 Jul 2017 09:23:02 +0800 From: Peter Xu Message-ID: <20170718012302.GX27284@pxdev.xzpeter.org> References: <20170717110936.23314-1-dgilbert@redhat.com> <20170717110936.23314-5-dgilbert@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20170717110936.23314-5-dgilbert@redhat.com> Subject: Re: [Qemu-devel] [PATCH v4 4/6] migration/rdma: Allow cancelling while waiting for wrid List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert (git)" Cc: qemu-devel@nongnu.org, quintela@redhat.com, lvivier@redhat.com On Mon, Jul 17, 2017 at 12:09:34PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > When waiting for a WRID, if the other side dies we end up waiting > for ever with no way to cancel the migration. > Cure this by poll()ing the fd first with a timeout and checking > error flags and migration state. > > Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu -- Peter Xu